[GitHub] [hive] maswin commented on pull request #4352: HIVE-27368: Addendum HIVE-26447 Vectorization: wrong results when filter on repeating map key orc table

["maswin (via GitHub)" <gi...@apache.org>]

maswin commented on PR #4352:
URL: https://github.com/apache/hive/pull/4352#issuecomment-1561793307

   > is there any scope to extend a test for this case? btw. you should create a new ticket for this rather than an addendum, [HIVE-26447](https://issues.apache.org/jira/browse/HIVE-26447) seems to be released, AFAIK addendums only till a ticket isn't released
   
   I can change the JIRA title if required. 
   Internally we have an ORC file in which this issue happens and we tested the query with the fix and it works fine. 
   For the issue to happen the keyStart array needs to have some garbage value, something other than 0 (probably due to array reuse) so that keyStart[keyOffset] returns some value other than 0. 
   When I test with small dataset and a simple query, since all values in the array are initialized to 0, keyStart[keyOffset] always returns 0 which is the expected start. Not sure how to add a simple test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org