You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by noobymatze <gi...@git.apache.org> on 2016/07/15 18:28:18 UTC
[GitHub] wicket pull request #174: WICKET-6203 rework IModel#mapWith
GitHub user noobymatze opened a pull request:
https://github.com/apache/wicket/pull/174
WICKET-6203 rework IModel#mapWith
I implemented the changes proposed in https://issues.apache.org/jira/browse/WICKET-6203.
Please don't hesitate to yell at me, if I did something wrong or something is missing. I tried to conform to the contribution guidelines.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/noobymatze/wicket rework-model-mapWith
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit a0c43bb9808c5e6b916e6461b357c3eaa4fa84fc
Author: Matthias Metzger <no...@yahoo.de>
Date: 2016-07-15T18:01:45Z
WICKET-6203 rework IModel#mapWith
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] wicket issue #174: WICKET-6203 rework IModel#mapWith
Posted by Andrea Del Bene <an...@gmail.com>.
Thank you Matthias, well done!
On 16/07/2016 10:48, martin-g wrote:
> Github user martin-g commented on the issue:
>
> https://github.com/apache/wicket/pull/174
>
> Thank you, Matthias!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] wicket issue #174: WICKET-6203 rework IModel#mapWith
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/174
Thank you, Matthias!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #174: WICKET-6203 rework IModel#mapWith
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #174: WICKET-6203 rework IModel#mapWith
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/174#discussion_r71063217
--- Diff: wicket-core/src/main/java/org/apache/wicket/model/IModel.java ---
@@ -113,7 +113,8 @@ default void detach()
}
/**
- * Returns a IModel applying the given mapper to the contained object, if it is not {@code null}.
+ * Returns a IModel applying the given mapper to the contained object, if it is not {@code null}
+ * .
--- End diff --
(yell) Please move the dot back on the previous line ! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---