You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/01 17:29:51 UTC

[GitHub] [beam] timrobertson100 edited a comment on pull request #15381: [BEAM-10990] Elasticsearch response filtering

timrobertson100 edited a comment on pull request #15381:
URL: https://github.com/apache/beam/pull/15381#issuecomment-910498732


   I'm sorry I haven't got time to complete a review, but I have read through the changes once, and it all looks well structured and has good attention to detail on comments, tests etc.
   
   The area I can't comment on immediately is the adapter and windowing behavior - if someone could confirm that section looks reasonable I think it looks good to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org