You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/04 07:03:38 UTC

[GitHub] [apisix] imjoey commented on issue #4150: bug: Inconsistent behavior of schema check for response-rewrite plugin between AdminAPI and ManagerAPI

imjoey commented on issue #4150:
URL: https://github.com/apache/apisix/issues/4150#issuecomment-831726093


   > @imjoey i guess the issue is resolved now, you can close the issue now
   > 
   > 
   
   @iamayushdas I'm afraid not yet. In ADMIN API, response-rewrite plug-in also checks if the input `body` is base64-decodable, while there is no such check in MANAGER API.
   
   Current checks performed in MANAGER API is merely property validation, without any logical checks like ADMIN API. While, there is no such similar mechanism for additional plug-in checks in MANAGER API. Probably we would better to define the `checkSchema` method within each plug-in if it requires additional checks. Then we can exact the plugins from request data and check what we want to.
   
   Please let me know what do you think. Thanks. @tokers @iamayushdas 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org