[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19514: [fix] [admin] Admin API can not work if uri too large

["Technoboy- (via GitHub)" <gi...@apache.org>]

Technoboy- commented on code in PR #19514:
URL: https://github.com/apache/pulsar/pull/19514#discussion_r1106870811


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/WebServer.java:
##########
@@ -214,6 +218,13 @@ public void addServlet(String basePath, ServletHolder servletHolder,
         handlers.add(context);
     }
 
+    private static void popularServletParams(ServletHolder servletHolder, ProxyConfiguration config){
+        if (config.getHttpClientRequestBufferSize() > 0 || config.getHttpMaxRequestHeaderSize() > 0){
+            int v = Math.max(config.getHttpClientRequestBufferSize(), config.getHttpMaxRequestHeaderSize());
+            servletHolder.setInitParameter(INIT_PARAM_REQUEST_BUFFER_SIZE, String.valueOf(v));
+        }
+    }

Review Comment:
   Why compare with `RequestHeaderSize` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org