You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/15 06:45:13 UTC

[GitHub] [incubator-nuttx-testing] yamt opened a new issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile

yamt opened a new issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile
URL: https://github.com/apache/incubator-nuttx-testing/issues/35
 
 
   cibuild.sh and docker/linux/Dockerfile have similar logic to install tools.
   IMO, the Dockerfile should use "cibuild.sh -i" to install tools.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile

Posted by GitBox <gi...@apache.org>.
btashton commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile
URL: https://github.com/apache/incubator-nuttx-testing/issues/35#issuecomment-613943681
 
 
   This still means you have a single huge intermediate stage and you lose all build caching of the image since you cannot cache the intermediate steps of the build. This is a large cost when trying to test and add new changes to the image and why I structured it this way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile

Posted by GitBox <gi...@apache.org>.
btashton commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile
URL: https://github.com/apache/incubator-nuttx-testing/issues/35#issuecomment-613850999
 
 
   The dockerfile is much more efficient and is also designed using multistage builds so it can easily be broken up to Target specific arch.  It is almost half the size you get by using the shell script install. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] yamt commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile

Posted by GitBox <gi...@apache.org>.
yamt commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile
URL: https://github.com/apache/incubator-nuttx-testing/issues/35#issuecomment-615070725
 
 
   i agree the way the Dockerfile version works is neat.
   but regardless of how good it is, IMO it's simpler to use a single copy (cibuild.sh) instead of two.
   
   anyway it's just my opinion.
   your opinion is more important as you are actually maintaining it.
   i'm closing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] yamt closed issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile

Posted by GitBox <gi...@apache.org>.
yamt closed issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile
URL: https://github.com/apache/incubator-nuttx-testing/issues/35
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] yamt commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile

Posted by GitBox <gi...@apache.org>.
yamt commented on issue #35: Redundant tool installation logic in cibuild.sh and Dockerfile
URL: https://github.com/apache/incubator-nuttx-testing/issues/35#issuecomment-613867621
 
 
   you can use cibuild.sh in an intermediate stage and COPY files in the last stage. this way the final image size should be almost same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services