You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rm...@apache.org on 2022/10/27 02:19:23 UTC

[logging-log4cxx] branch LOGCXX-562 updated: Better check for libfmt

This is an automated email from the ASF dual-hosted git repository.

rmiddleton pushed a commit to branch LOGCXX-562
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git


The following commit(s) were added to refs/heads/LOGCXX-562 by this push:
     new 7f0395be Better check for libfmt
7f0395be is described below

commit 7f0395be09e69ca17c1531ee348268d507b2e807
Author: Robert Middleton <ro...@rm5248.com>
AuthorDate: Wed Oct 26 22:19:17 2022 -0400

    Better check for libfmt
---
 .github/workflows/log4cxx-posix.yml | 3 ---
 src/examples/cpp/CMakeLists.txt     | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/.github/workflows/log4cxx-posix.yml b/.github/workflows/log4cxx-posix.yml
index a50bdc42..92e7b64f 100644
--- a/.github/workflows/log4cxx-posix.yml
+++ b/.github/workflows/log4cxx-posix.yml
@@ -71,13 +71,10 @@ jobs:
         sudo apt-get install -y libapr1-dev libaprutil1-dev libfmt-dev
 
     - name: 'run cmake - posix'
-      shell: bash
       run: |
         cd main
         mkdir build
         cd build
-        ls /usr/local/include
-        ls /usr/include/fmt
         cmake -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} -DCMAKE_C_COMPILER=${{ matrix.cc }} ..
         cmake --build .
 
diff --git a/src/examples/cpp/CMakeLists.txt b/src/examples/cpp/CMakeLists.txt
index cfb2fe7a..be6092de 100644
--- a/src/examples/cpp/CMakeLists.txt
+++ b/src/examples/cpp/CMakeLists.txt
@@ -29,7 +29,7 @@ configure_file( custom-appender.xml
     COPYONLY )
 
 # Custom handling for format string example, since it utilizes libfmt
-find_package(fmt QUIET)
+find_package(fmt 6.0 QUIET)
 if(${fmt_FOUND})
     add_executable( format-string format-string.cpp )
     target_compile_definitions(format-string PRIVATE ${LOG4CXX_COMPILE_DEFINITIONS} ${APR_COMPILE_DEFINITIONS} ${APR_UTIL_COMPILE_DEFINITIONS} )