[GitHub] [dolphinscheduler] mgsky1 commented on a change in pull request #6167: [Fix-6166][task-plugin]Fix Python Task Execution Error

[GitBox <gi...@apache.org>]

mgsky1 commented on a change in pull request #6167:
URL: https://github.com/apache/dolphinscheduler/pull/6167#discussion_r706292952



##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonTask.java
##########
@@ -95,8 +100,8 @@ public void setCommand(String command) {
     public void handle() throws Exception {
         try {
             //    construct process
+            this.command = buildCommand();
             TaskResponse taskResponse = pythonCommandExecutor.run(command);

Review comment:
       Did you mean it is better to use local variables like `pyCommand` but NOT `this.command`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org