[GitHub] [pulsar] Jason918 commented on a diff in pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#discussion_r890723964


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2000,7 +2000,8 @@ public class ServiceConfiguration implements PulsarConfiguration {
     @FieldContext(
         category = CATEGORY_LOAD_BALANCER,
         deprecated = true,
-        doc = "Usage threshold to determine a broker as under-loaded (only used by SimpleLoadManagerImpl)"
+        doc = "Usage threshold to determine a broker as under-loaded (used by SimpleLoadManagerImpl and "
+                + "ModularLoadManagerImpl)"

Review Comment:
   Can you point out where this is used in `ModularLoadManagerImpl`？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org