You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "calvin xiu (JIRA)" <ji...@apache.org> on 2011/05/20 09:36:47 UTC

[jira] [Created] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

LogoutFilter should catch the  InvalidSessionException 
-------------------------------------------------------

                 Key: SHIRO-298
                 URL: https://issues.apache.org/jira/browse/SHIRO-298
             Project: Shiro
          Issue Type: Bug
            Reporter: calvin xiu
            Priority: Minor


Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037023#comment-13037023 ] 

Kalle Korhonen commented on SHIRO-298:
--------------------------------------

Client tries to use a session that has expired already, right? There are lots of cases where some existing system invalidates user's session before Shiro, so I'd say this is valid.

> LogoutFilter should catch the  InvalidSessionException 
> -------------------------------------------------------
>
>                 Key: SHIRO-298
>                 URL: https://issues.apache.org/jira/browse/SHIRO-298
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.2.0
>            Reporter: calvin xiu
>            Priority: Minor
>
> Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

Posted by "calvin xiu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

calvin xiu updated SHIRO-298:
-----------------------------

          Component/s: Web
    Affects Version/s: 1.2.0

> LogoutFilter should catch the  InvalidSessionException 
> -------------------------------------------------------
>
>                 Key: SHIRO-298
>                 URL: https://issues.apache.org/jira/browse/SHIRO-298
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.2.0
>            Reporter: calvin xiu
>            Priority: Minor
>
> Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

Posted by "Les Hazlewood (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Les Hazlewood closed SHIRO-298.
-------------------------------


Closing with the 1.2.0 release.
                
> LogoutFilter should catch the  InvalidSessionException 
> -------------------------------------------------------
>
>                 Key: SHIRO-298
>                 URL: https://issues.apache.org/jira/browse/SHIRO-298
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.2.0
>            Reporter: calvin xiu
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036994#comment-13036994 ] 

Les Hazlewood commented on SHIRO-298:
-------------------------------------

How is it possible that the Session is invalid before this filter is invoked?

The ShiroFilter that constructs the Subject instance ensures the Session is valid before the rest of the filter chain executes.

Are you calling httpSession.invalidate() before calling Subject.logout()?

If so, that is not necessary - Subject.logout() will invalidate the session automatically.

> LogoutFilter should catch the  InvalidSessionException 
> -------------------------------------------------------
>
>                 Key: SHIRO-298
>                 URL: https://issues.apache.org/jira/browse/SHIRO-298
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.2.0
>            Reporter: calvin xiu
>            Priority: Minor
>
> Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

Posted by "calvin xiu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHIRO-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037284#comment-13037284 ] 

calvin xiu commented on SHIRO-298:
----------------------------------

yes, the http session is easy to expire, so the logout filter catch this exception will be better.

> LogoutFilter should catch the  InvalidSessionException 
> -------------------------------------------------------
>
>                 Key: SHIRO-298
>                 URL: https://issues.apache.org/jira/browse/SHIRO-298
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.2.0
>            Reporter: calvin xiu
>            Priority: Minor
>
> Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SHIRO-298) LogoutFilter should catch the InvalidSessionException

Posted by "Les Hazlewood (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Les Hazlewood resolved SHIRO-298.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.0
    
> LogoutFilter should catch the  InvalidSessionException 
> -------------------------------------------------------
>
>                 Key: SHIRO-298
>                 URL: https://issues.apache.org/jira/browse/SHIRO-298
>             Project: Shiro
>          Issue Type: Bug
>          Components: Web
>    Affects Versions: 1.2.0
>            Reporter: calvin xiu
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Should catch InvalidSessionException for session timeout problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira