You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Mck SembWever (JIRA)" <ji...@apache.org> on 2010/05/01 17:53:56 UTC

[jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

    [ https://issues.apache.org/jira/browse/TILES-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863021#action_12863021 ] 

Mck SembWever commented on TILES-506:
-------------------------------------

patches applied. fixes committed into tiles/site as well.
tiles-master now uses apache pom version 7.
remaining is to release tiles-master to version 2 and then update the other top-level tiles pom files.

> Fix link to jira under "Project Information --> Issue tracking"
> ---------------------------------------------------------------
>
>                 Key: TILES-506
>                 URL: https://issues.apache.org/jira/browse/TILES-506
>             Project: Tiles
>          Issue Type: Bug
>          Components: site
>            Reporter: Mck SembWever
>             Fix For: 2.2.2
>
>         Attachments: TILES-506.patch, TILES-MASTER.506
>
>
> Currently the link points to https://issues.apache.org/struts/browse/TILES

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [OT] jira workflow WAS: Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Antonio Petrelli <an...@gmail.com>.
2010/5/4 Mck <mi...@semb.wever.org>:
> On Tue, 2010-05-04 at 09:35 +0200, Antonio Petrelli wrote:
>> Not the issue, the version in the "Fix for" field of Jira issues. The
>> issues should be moved to a higher version.
>
> Couldn't this just be done in the same bulk step as when you change all
> the issues to closed?
> That is all those resolved issues remain resolved until one of the "test
> builds" is successfully made into a release X.Y.Z. At that point then
> all those resolved issues are bulk changed to "closed" and "Fix for
> X.Y.X".

We want to avoid the bulk change from resolved to closed, not the "fix
fore" bulk change. The latter is mandatory anyway.

> It's not so important, as i've marked the subject OT

Why? It's perfectly On Topic!

> but i'm presuming
> that apache doesn't give anyone here the rights to remove the "resolved"
> state from the TILES jira project, and so am wondering if there's a way
> to better use it. Nobody likes dead wood!

I did not try, but probably I can create a separate custom workflow as
I did in Struts' Jira.
I can try it this evening (CET) at home if you like.

Antonio

[OT] jira workflow WAS: Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
On Tue, 2010-05-04 at 09:35 +0200, Antonio Petrelli wrote:
> Not the issue, the version in the "Fix for" field of Jira issues. The
> issues should be moved to a higher version.

Couldn't this just be done in the same bulk step as when you change all
the issues to closed?
That is all those resolved issues remain resolved until one of the "test
builds" is successfully made into a release X.Y.Z. At that point then
all those resolved issues are bulk changed to "closed" and "Fix for
X.Y.X".

It's not so important, as i've marked the subject OT, but i'm presuming
that apache doesn't give anyone here the rights to remove the "resolved"
state from the TILES jira project, and so am wondering if there's a way
to better use it. Nobody likes dead wood!

> Anyway, your questions are always welcome! 

Thanks. There are many ways of organising an issue tracker so it's nice
to know how tiles does it, and to just learn another way. 

~mck

-- 
"The rainbow would not be without first the rain." D Donche Jr 
| http://semb.wever.org | http://sesat.no | http://finn.no |

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
> > I've just discovered the TILESHARED jira project!
> > This of course forms the proper release notes :-)
> > Should I move TILES-506 to TILESSHARED ?
> 
> Not move, since there is a (small) part in the Tiles framework itself,
> so create another issue please.

Ok. I create a clone and moved that to TILESSHARED.
I also created versions 1 and 2 and 3 in TILESSHARED. 
(1 being released already).

~mck
 
-- 
"When you say: "I wrote a program that crashed Windows", people just
stare at you blankly and say: "Hey, I got those with the system -- for
free."" Linus Torvalds 
| http://semb.wever.org | http://sesat.no | http://finn.no |

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Antonio Petrelli <an...@gmail.com>.
2010/5/4 Mck <mi...@semb.wever.org>:
>> Sorry if I've not been clearer before, but after several years here
>> I've taken for granted some things that might not be clear for new
>> people.
>
> I've just discovered the TILESHARED jira project!
> This of course forms the proper release notes :-)
> Should I move TILES-506 to TILESSHARED ?

Not move, since there is a (small) part in the Tiles framework itself,
so create another issue please.

Antonio

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
> Sorry if I've not been clearer before, but after several years here
> I've taken for granted some things that might not be clear for new
> people. 

I've just discovered the TILESHARED jira project!
This of course forms the proper release notes :-)
Should I move TILES-506 to TILESSHARED ?

And covering out jira workflow discussion:
 https://issues.apache.org/jira/browse/TILESSHARED-5
 http://www.mail-archive.com/dev@tiles.apache.org/msg00235.html
it seems history repeats itself (sorry for not STFW earlier)...

~mck

-- 
"Never let your sense of morals get in the way of doing what's right."
Isaac Asimov 
| http://semb.wever.org | http://sesat.no | http://finn.no |

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Antonio Petrelli <an...@gmail.com>.
2010/5/4 Mck <mi...@semb.wever.org>:
>
>> >  In this manner the release process itself substitutes as the quality
>> > assurance.
>>
>> In fact, in the early days of Tiles we did like this, but, in fact,
>> the "resolved" state is still without meaning.
>> Suppose that a build fails, you have to declare the version "invalid"
>> and move all the issues to another version. This step is needed even
>> if you use "resolved" state.
>
> I don't quite understand you.
> In this context what do you mean the "build failed" ?

I used the wrong term, sorry. I meant "leave as a test build". A long
time ago we voted against a test build because it did not contain
javadocs.

> And why would the
> issue be invalid?

Not the issue, the version in the "Fix for" field of Jira issues. The
issues should be moved to a higher version.
A thing that you might not have noticed is that we adopted an "always
increase" build numbers. We do not use RC, Beta etc. in version
numbers. We use X.Y.Z scheme plus a judgment about its
maturity/stability (Alpha, Beta, GA, only a test build).

Sorry if I've not been clearer before, but after several years here
I've taken for granted some things that might not be clear for new
people.
Anyway, your questions are always welcome!

Antonio

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
> >  In this manner the release process itself substitutes as the quality
> > assurance.
> 
> In fact, in the early days of Tiles we did like this, but, in fact,
> the "resolved" state is still without meaning.
> Suppose that a build fails, you have to declare the version "invalid"
> and move all the issues to another version. This step is needed even
> if you use "resolved" state.

I don't quite understand you.
In this context what do you mean the "build failed" ? And why would the
issue be invalid?

> >> Not necessarily. If you like, you can deploy a snapshot (mvn deploy),
> >> let the other project depend on the snapshot
> >
> > I'm not very fond of inheriting from SNAPSHOT parents. Apart from the
> > project instability it introduces it also slows down every build.
> 
> Ok for the instability, but it is resolved when it is released thanks
> to the Maven release plugin that checks the presence of snapshots. 

Yes of course. thanks for your patience. 
Then I've made the commit so to use 2-SNAPSHOT, and i'll update the site
latter today.

~mck

-- 
To mess up a Linux box, you need to work at it; to mess up your Windows
box, you just need to work on it. 
| http://semb.wever.org | http://sesat.no | http://finn.no |

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Antonio Petrelli <an...@gmail.com>.
2010/5/3 Mck <mi...@semb.wever.org>:
>  Instead when a release is made part of the release process is to bulk
> transit all resolved issues over to closed.
>  In this manner the release process itself substitutes as the quality
> assurance.

In fact, in the early days of Tiles we did like this, but, in fact,
the "resolved" state is still without meaning.
Suppose that a build fails, you have to declare the version "invalid"
and  move all the issues to another version. This step is needed even
if you use "resolved" state.

>> > ... That is after tiles-master is (voted and)
>> > released to version 2 then the other pom files must be updated and
>> > committed. Only then the website will have correct links to the
>> > issue-tracker?
>>
>> Not necessarily. If you like, you can deploy a snapshot (mvn deploy),
>> let the other project depend on the snapshot
>
> I'm not very fond of inheriting from SNAPSHOT parents. Apart from the
> project instability it introduces it also slows down every build.

Ok for the instability, but it is resolved when it is released thanks
to the Maven release plugin that checks the presence of snapshots.
About the slowdown, what do you mean? I don't think it is so tragic,
and you can still build offline.

Antonio

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
> >> First of all please close the TILES-506 issue.
> > Done.
> Ok, but you can close directly the issue, not passing the "resolved"
> state. When we were on the other JIRA instance, we created a custom
> workflow without the "resolved" and other states, since, in our case,
> they are meaningless.

Ok. thanks for the explanation. my question was more around why the
issue was no longer "in progress"... but that's not so important.

> Usually, resolved means that the developer thinks he had finished his work.
> Closed means that the reporter tested it and says that it works.
> Usually we don't have such a feedback from the reporter, so the
> "resolved" state is useless.

 A different approach... for situations like this where quality assurance
by the reporter really can't be relied upon, is to use the "resolved"
state for those issue fixed but not yet available in any release.
 That makes it simpler for developers because they don't need to resolve
and close (or remember to directly close) the issue every time.
 Instead when a release is made part of the release process is to bulk
transit all resolved issues over to closed.
 In this manner the release process itself substitutes as the quality
assurance. 

> > ... That is after tiles-master is (voted and)
> > released to version 2 then the other pom files must be updated and
> > committed. Only then the website will have correct links to the
> > issue-tracker?
> 
> Not necessarily. If you like, you can deploy a snapshot (mvn deploy),
> let the other project depend on the snapshot 

I'm not very fond of inheriting from SNAPSHOT parents. Apart from the
project instability it introduces it also slows down every build.

~mck

-- 
"When there is no enemy within, the enemies outside can't hurt you."
African proverb 
| http://semb.wever.org | http://sesat.no | http://finn.no |


Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Antonio Petrelli <an...@gmail.com>.
2010/5/2 Mck <mi...@semb.wever.org>:
>
>> First of all please close the TILES-506 issue.
>
> Done.

Ok, but you can close directly the issue, not passing the "resolved"
state. When we were on the other JIRA instance, we created a custom
workflow without the "resolved" and other states, since, in our case,
they are meaningless.
Usually, resolved means that the developer thinks he had finished his work.
Closed means that the reporter tested it and says that it works.
Usually we don't have such a feedback from the reporter, so the
"resolved" state is useless.

> But may i ask why? since i know that more commits will be necessary
> before the fix is complete. That is after tiles-master is (voted and)
> released to version 2 then the other pom files must be updated and
> commited. Only then the website will have correct links to the
> issue-tracker?

Not necessarily. If you like, you can deploy a snapshot (mvn deploy),
let the other project depend on the snapshot and deploy the website
(mvn site:deploy).

Antonio

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
> First of all please close the TILES-506 issue.

Done. 

But may i ask why? since i know that more commits will be necessary
before the fix is complete. That is after tiles-master is (voted and)
released to version 2 then the other pom files must be updated and
commited. Only then the website will have correct links to the
issue-tracker?

~mck

-- 
"The possibility that we may fail in the struggle should not deter us
from supporting a cause we believe to be just." Abraham Lincoln 
| semb.wever.org | sesat.no | finn.no |

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Antonio Petrelli <an...@gmail.com>.
2010/5/2 Mck <mi...@semb.wever.org>:
> From https://issues.apache.org/jira/browse/TILES-506
>
>> Mck SembWever commented on TILES-506:
>> -------------------------------------
>>
>> patches applied. fixes committed into tiles/site as well.
>> tiles-master now uses apache pom version 7.
>> remaining is to release tiles-master to version 2 and then update the
>> other top-level tiles pom files.
>
> How do i go about making such a release for the tiles-master project
> located at https://svn.eu.apache.org/repos/asf/tiles/maven/trunk/pom ?
>
> It is just to `mvn release:prepare` and `mvn release:perform` ?
> Or does this too need to go through the full release process?

First of all please close the TILES-506 issue.
For the rest (other members please correct me if I am wrong), since it
is not a package and it's only a matter of a POM file, I think you can
call for a vote *before* releasing it for real.
After a successful vote, you can release it (prepare and perform).
Remember to add your own keys before releasing!

Antonio

Re: [jira] Commented: (TILES-506) Fix link to jira under "Project Information --> Issue tracking"

Posted by Mck <mi...@semb.wever.org>.
From https://issues.apache.org/jira/browse/TILES-506

> Mck SembWever commented on TILES-506:
> -------------------------------------
> 
> patches applied. fixes committed into tiles/site as well.
> tiles-master now uses apache pom version 7.
> remaining is to release tiles-master to version 2 and then update the
> other top-level tiles pom files. 

How do i go about making such a release for the tiles-master project
located at https://svn.eu.apache.org/repos/asf/tiles/maven/trunk/pom ?

It is just to `mvn release:prepare` and `mvn release:perform` ?
Or does this too need to go through the full release process?

~mck

-- 
"Buddhism has the characteristics of what would be expected in a cosmic
religion for the future: It transcends a personal God, avoids dogmas and
theology; it covers both the natural and the spiritual, and it is based
on a religious sense aspiring from the experience of all things, natural
and spiritual, as a meaningful unity." Albert Einstein 
| semb.wever.org | sesat.no | finn.no |