You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Johannes Weberhofer (JIRA)" <ji...@apache.org> on 2009/11/11 23:16:40 UTC
[jira] Created: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
-----------------------------------------------------------------------------------------------------
Key: GERONIMODEVTOOLS-599
URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
Project: Geronimo-Devtools
Issue Type: Improvement
Components: eclipse-plugin
Affects Versions: 2.2.0
Environment: linux x86_64
Reporter: Johannes Weberhofer
Assignee: Tim McConnell
* Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
* simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
* a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920366#action_12920366 ]
Ted Kirby commented on GERONIMODEVTOOLS-599:
--------------------------------------------
with rev 1021938, I finished off my reworked version of Johannes enhancements with the testsuite pieces:
Call /eclipse/build.xml to get eclipse, don't replicate its code in /testsuite/eclipse/build.xml
Simplify /testsuite/eclipse/pom.xml by having ant <os family> determine environment, don't need maven to.
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919318#action_12919318 ]
Ted Kirby commented on GERONIMODEVTOOLS-599:
--------------------------------------------
I simplified further by reworking build.xml using conditional property settings.
I simplified pom.xml by having ant <os family> determine environment, don't need maven to.
Rev 1005892.
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919137#action_12919137 ]
Ted Kirby commented on GERONIMODEVTOOLS-599:
--------------------------------------------
I liked your build.xml simplifications, Johannes. I was inspired to extend your ideas and refactor the code so common code only appears once. I think we'll have to tweak it to account for some minor differences between initial major eclipse releases and the subsequent SRn releases, but I think we have an improved version that will make this much easier.
See my changes in rev 1005697.
I think Delos did your pom changes in GERONIMODEVTOOLS-600, with his excellent sun.arch.data.model work.
I also want to apply this build.xml rework to testsuite/eclipse/build.xml, as you suggested, but I want to get the testsuite build to work for me first. I am missing some artifacts as noted in GERONIMODEVTOOLS-675.
Thanks again for the patch Johannes.
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798580#action_12798580 ]
Delos Dai commented on GERONIMODEVTOOLS-599:
--------------------------------------------
Hi Johannes,
Thanks for your patch!
The last two items in your description seems OK for me. I will commit the patch.
But I'm not clear about your fix for first item. It only add x86 arch,but it will failed on OS which returns x86_64. Are you sure you're using a x86_64 OS?
For the building problem on 64 bit system, I think the root cause is the detecting mechanism. Currently, in build.xml, we make use of architecture detecting in maven activation. In fact, it's based on the value of System.getProperty("os.arch"). The issue is that the value returned by this method is not predictable. Take Linux for example, different Linux kernel or JDK may returns different values for the same architecture. More details, you can refer to http://lopica.sourceforge.net/os.html.
Besides the issue above, I think we made a mistake to detect the OS architecture. The right thing we have to detect is the data model(32bit or 64bit) of JDK, instead of the OS architecture, because a 32-bit JDK can also be used in a 64-bit OS. Therefor, I searched another property to get the data model of JDK. Now, the property I found is "sun.arch.data.model". The value System.getProperty("sun.arch.data.model") is 32 for 32-bit JDK or 64 for 64-bit JDK. Although it's not a standard property in JDK API doc, I have tried it with both 5.0 and 6.0 JDK.
To resolve the issue of JDK data model, I think we have to make use of property "sun.arch.data.model". I have created GERONIMODEVTOOLS-600 to track the improvement based on property "sun.arch.data.model".
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby updated GERONIMODEVTOOLS-599:
---------------------------------------
Fix Version/s: 3.0
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Fix For: 3.0
>
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798581#action_12798581 ]
Delos Dai commented on GERONIMODEVTOOLS-599:
--------------------------------------------
#897745 for trunk. Thanks Johannes for the patch!
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799021#action_12799021 ]
Delos Dai commented on GERONIMODEVTOOLS-599:
--------------------------------------------
Currently, the vote for GEP 2.2 is under going. It's better for us to change the code as little as possible, so I didn't apply all the patches yet. I will apply them all once the release is done.
For GERONIMODEVTOOLS-600, I planned to work on it later, so no available patch yet. If you like, you can have a try. Thanks!
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Johannes Weberhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798617#action_12798617 ]
Johannes Weberhofer commented on GERONIMODEVTOOLS-599:
------------------------------------------------------
Hi Delos,
regarding to the architecture, I'm building on an openSUSE AMD 64bit system, on which my patch worked well. I agree, that detection of "sun.arch.data.model" could be much better as the "os.arch" seem to return different values on different operating systems on the same architecture. Do you already have a patch for GERONIMODEVTOOLS-600, which I could test? Elsewise I could prepeare a patch.
I have not found the simplification-patches in the latest sources. What do you think about those?
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922152#action_12922152 ]
Ted Kirby commented on GERONIMODEVTOOLS-599:
--------------------------------------------
fix testsuite launching on 64-bit machines with rev 1023908.
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Fix For: 3.0
>
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-599) Compilation on x86_64
systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite
fixes
Posted by "Johannes Weberhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johannes Weberhofer updated GERONIMODEVTOOLS-599:
-------------------------------------------------
Attachment: gep-x86_64_and_simplifications.patch
> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-599
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.2.0
> Environment: linux x86_64
> Reporter: Johannes Weberhofer
> Assignee: Tim McConnell
> Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml file again and replaced i386 architecture by x86; hope, this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general "eclipse" parameter, which makes changes between eclipse releases much easier (changes have to be done in the header sections only). At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on the common target. The testsuite runs much better now on x86_64 (but still produces an error)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.