You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2021/01/08 23:50:06 UTC

svn commit: r1885281 [3/11] - in /poi/trunk/src: multimodule/poi/test9/ ooxml/testcases/org/apache/poi/xssf/streaming/ ooxml/testcases/org/apache/poi/xssf/usermodel/ testcases/org/apache/poi/ testcases/org/apache/poi/ddf/ testcases/org/apache/poi/hpsf/...

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java Fri Jan  8 23:50:02 2021
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
 public final class TestBoolErrRecord {
 
 	@Test
-	public void testError() {
+	void testError() {
 		byte[] data = HexRead.readFromString(
 				"00 00 00 00 0F 00 " + // row, col, xfIndex
 				"07 01 " // #DIV/0!, isError
@@ -54,7 +54,7 @@ public final class TestBoolErrRecord {
 	 * work by the same coincidence).
 	 */
 	@Test
-	public void testOooBadFormat_bug47479() {
+	void testOooBadFormat_bug47479() {
 		byte[] data = HexRead.readFromString(
 				"05 02 09 00 " + // sid, size
 				"00 00 00 00 0F 00 " + // row, col, xfIndex

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java Fri Jan  8 23:50:02 2021
@@ -35,25 +35,25 @@ import org.junit.jupiter.api.Test;
 public final class TestBoundSheetRecord {
 
 	@Test
-	public void testRecordLength() {
+	void testRecordLength() {
 		BoundSheetRecord record = new BoundSheetRecord("Sheet1");
 		assertEquals(18, record.getRecordSize());
 	}
 
 	@Test
-	public void testWideRecordLength() {
+	void testWideRecordLength() {
 		BoundSheetRecord record = new BoundSheetRecord("Sheet\u20ac");
 		assertEquals(24, record.getRecordSize());
 	}
 
 	@Test
-	public void testName() {
+	void testName() {
 		BoundSheetRecord record = new BoundSheetRecord("1234567890223456789032345678904");
 		assertThrows(IllegalArgumentException.class, () -> record.setSheetname("s//*s"));
 	}
 
 	@Test
-	public void testDeserializeUnicode() {
+	void testDeserializeUnicode() {
 
 		byte[] data = HexRead.readFromString(""
 			+ "85 00 1A 00" // sid, length
@@ -76,7 +76,7 @@ public final class TestBoundSheetRecord
 	}
 
 	@Test
-	public void testOrdering() {
+	void testOrdering() {
 		BoundSheetRecord bs1 = new BoundSheetRecord("SheetB");
 		BoundSheetRecord bs2 = new BoundSheetRecord("SheetC");
 		BoundSheetRecord bs3 = new BoundSheetRecord("SheetA");
@@ -97,7 +97,7 @@ public final class TestBoundSheetRecord
 	}
 
 	@Test
-	public void testValidNames() {
+	void testValidNames() {
 		assertTrue(isValid("Sheet1"));
 		assertTrue(isValid("O'Brien's sales"));
 		assertTrue(isValid(" data # "));

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java Fri Jan  8 23:50:02 2021
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
  */
 public final class TestCFHeaderRecord {
 	@Test
-	public void testCreateCFHeaderRecord () {
+	void testCreateCFHeaderRecord () {
 		CFHeaderRecord record = new CFHeaderRecord();
 		CellRangeAddress[] ranges = {
 			new CellRangeAddress(0,0xFFFF,5,5),
@@ -64,7 +64,7 @@ public final class TestCFHeaderRecord {
 	}
 
 	@Test
-    public void testCreateCFHeader12Record () {
+    void testCreateCFHeader12Record () {
         CFHeader12Record record = new CFHeader12Record();
         CellRangeAddress[] ranges = {
             new CellRangeAddress(0,0xFFFF,5,5),
@@ -97,7 +97,7 @@ public final class TestCFHeaderRecord {
     }
 
 	@Test
-	public void testSerialization() {
+	void testSerialization() {
 		byte[] recordData =
 		{
 			(byte)0x03, (byte)0x00,
@@ -149,7 +149,7 @@ public final class TestCFHeaderRecord {
 	}
 
 	@Test
-	public void testExtremeRows() {
+	void testExtremeRows() {
 		byte[] recordData = {
 			(byte)0x13, (byte)0x00, // nFormats
 			(byte)0x00,	(byte)0x00,

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java Fri Jan  8 23:50:02 2021
@@ -50,7 +50,7 @@ import org.junit.jupiter.api.Test;
  */
 public final class TestCFRuleRecord {
     @Test
-    public void testConstructors () throws IOException {
+    void testConstructors () throws IOException {
         try (HSSFWorkbook workbook = new HSSFWorkbook()) {
             HSSFSheet sheet = workbook.createSheet();
 
@@ -76,7 +76,7 @@ public final class TestCFRuleRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testCreateCFRuleRecord() throws IOException {
+    void testCreateCFRuleRecord() throws IOException {
         try (HSSFWorkbook workbook = new HSSFWorkbook()) {
             HSSFSheet sheet = workbook.createSheet();
             CFRuleRecord record = CFRuleRecord.create(sheet, "7");
@@ -99,7 +99,7 @@ public final class TestCFRuleRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testCreateCFRule12Record() throws IOException {
+    void testCreateCFRule12Record() throws IOException {
         try (HSSFWorkbook workbook = new HSSFWorkbook()) {
             HSSFSheet sheet = workbook.createSheet();
             CFRule12Record record = CFRule12Record.create(sheet, "7");
@@ -121,7 +121,7 @@ public final class TestCFRuleRecord {
     }
 
     @Test
-    public void testCreateIconCFRule12Record() throws IOException {
+    void testCreateIconCFRule12Record() throws IOException {
         try (HSSFWorkbook workbook = new HSSFWorkbook()) {
             HSSFSheet sheet = workbook.createSheet();
             CFRule12Record record = CFRule12Record.create(sheet, IconSet.GREY_5_ARROWS);
@@ -372,7 +372,7 @@ public final class TestCFRuleRecord {
     }
 
     @Test
-    public void testWrite() throws IOException {
+    void testWrite() throws IOException {
         try (HSSFWorkbook workbook = new HSSFWorkbook()) {
             HSSFSheet sheet = workbook.createSheet();
             CFRuleRecord rr = CFRuleRecord.create(sheet, ComparisonOperator.BETWEEN, "5", "10");
@@ -410,7 +410,7 @@ public final class TestCFRuleRecord {
      * tRefN and tAreaN tokens must be preserved when re-serializing conditional format formulas
      */
     @Test
-    public void testReserializeRefNTokens() {
+    void testReserializeRefNTokens() {
 
         RecordInputStream is = TestcaseRecordInputStream.create(CFRuleRecord.sid, DATA_REFN);
         CFRuleRecord rr = new CFRuleRecord(is);
@@ -427,7 +427,7 @@ public final class TestCFRuleRecord {
     }
 
     @Test
-    public void testBug53691() throws IOException {
+    void testBug53691() throws IOException {
         try (HSSFWorkbook workbook = new HSSFWorkbook()) {
             HSSFSheet sheet = workbook.createSheet();
 
@@ -442,7 +442,7 @@ public final class TestCFRuleRecord {
     }
 
     @Test
-    public void testBug57231_rewrite() throws IOException {
+    void testBug57231_rewrite() throws IOException {
         try (HSSFWorkbook wb1 = HSSFITestDataProvider.instance.openSampleWorkbook("57231_MixedGasReport.xls")) {
             assertEquals(7, wb1.getNumberOfSheets());
             try (HSSFWorkbook wb2 = HSSFITestDataProvider.instance.writeOutAndReadBack(wb1)) {

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java Fri Jan  8 23:50:02 2021
@@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test;
 public final class TestColumnInfoRecord {
 
 	@Test
-	public void testBasic() {
+	void testBasic() {
 		byte[] data = HexRead.readFromString("7D 00 0C 00 14 00 9B 00 C7 19 0F 00 01 13 00 00");
 
 		RecordInputStream in = TestcaseRecordInputStream.create(data);
@@ -53,7 +53,7 @@ public final class TestColumnInfoRecord
 	 * Excel reads that file OK and assumes zero for the value of the reserved field.
 	 */
 	@Test
-	public void testZeroResevedBytes_bug48332() {
+	void testZeroResevedBytes_bug48332() {
 		// Taken from bugzilla attachment 24661 (offset 0x1E73)
 		byte[] inpData = HexRead.readFromString("7D 00 0A 00 00 00 00 00 D5 19 0F 00 02 00");
 		byte[] outData = HexRead.readFromString("7D 00 0C 00 00 00 00 00 D5 19 0F 00 02 00 00 00");
@@ -71,7 +71,7 @@ public final class TestColumnInfoRecord
 	 * but this seems to cause no problem to Excel
 	 */
 	@Test
-	public void testOneReservedByte() {
+	void testOneReservedByte() {
 		byte[] inpData = HexRead.readFromString("7D 00 0B 00 00 00 00 00 24 02 0F 00 00 00 01");
 		byte[] outData = HexRead.readFromString("7D 00 0C 00 00 00 00 00 24 02 0F 00 00 00 01 00");
 		RecordInputStream in = TestcaseRecordInputStream.create(inpData);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java Fri Jan  8 23:50:02 2021
@@ -40,7 +40,7 @@ public final class TestCommonObjectDataS
 	};
 
 	@Test
-	public void testLoad() {
+	void testLoad() {
 		CommonObjectDataSubRecord record = new CommonObjectDataSubRecord(TestcaseRecordInputStream.createLittleEndian(data), data.length);
 
 		assertEquals( CommonObjectDataSubRecord.OBJECT_TYPE_LIST_BOX, record.getObjectType());
@@ -58,7 +58,7 @@ public final class TestCommonObjectDataS
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testStore() {
+	void testStore() {
 		CommonObjectDataSubRecord record = new CommonObjectDataSubRecord();
 
 		record.setObjectType(CommonObjectDataSubRecord.OBJECT_TYPE_LIST_BOX);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDConRefRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDConRefRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDConRefRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDConRefRecord.java Fri Jan  8 23:50:02 2021
@@ -177,7 +177,7 @@ public class TestDConRefRecord {
      * various flavours. This uses the RecordInputStream constructor.
      */
     @Test
-    public void testReadWriteSBExtRef() throws IOException {
+    void testReadWriteSBExtRef() throws IOException {
         testReadWrite(data1, "read-write single-byte external reference, volume type path");
         testReadWrite(volumeString,
                 "read-write properly formed single-byte external reference, volume type path");
@@ -202,7 +202,7 @@ public class TestDConRefRecord {
      * string
      */
     @Test
-    public void testReadWriteDBExtRefUncVol() throws IOException {
+    void testReadWriteDBExtRefUncVol() throws IOException {
         testReadWrite(data4, "read-write double-byte external reference, UNC volume type path");
     }
 
@@ -221,7 +221,7 @@ public class TestDConRefRecord {
      * test read-constructor-then-serialize for a double-byte self-reference style string
      */
     @Test
-    public void testReadWriteDBSelfRef() throws IOException {
+    void testReadWriteDBSelfRef() throws IOException {
         testReadWrite(data2, "read-write double-byte self reference");
     }
 
@@ -229,7 +229,7 @@ public class TestDConRefRecord {
      * test read-constructor-then-serialize for a single-byte self-reference style string
      */
     @Test
-    public void testReadWriteSBSelfRef() throws IOException {
+    void testReadWriteSBSelfRef() throws IOException {
         testReadWrite(data3, "read-write single byte self reference");
     }
 
@@ -237,7 +237,7 @@ public class TestDConRefRecord {
      * Test of getDataSize method, of class DConRefRecord.
      */
     @Test
-    public void testGetDataSize() {
+    void testGetDataSize() {
         DConRefRecord instance = new DConRefRecord(TestcaseRecordInputStream.create(81, data1));
         int expResult = data1.length;
         int result = instance.getDataSize();
@@ -255,7 +255,7 @@ public class TestDConRefRecord {
      * Test of getSid method, of class DConRefRecord.
      */
     @Test
-    public void testGetSid() {
+    void testGetSid() {
         DConRefRecord instance = new DConRefRecord(TestcaseRecordInputStream.create(81, data1));
         short expResult = 81;
         short result = instance.getSid();
@@ -266,7 +266,7 @@ public class TestDConRefRecord {
      * Test of getPath method, of class DConRefRecord.
      */
     @Test
-    public void testGetPath() {
+    void testGetPath() {
         // TODO: different types of paths.
         DConRefRecord instance = new DConRefRecord(TestcaseRecordInputStream.create(81, data1));
         byte[] expResult = Arrays.copyOfRange(data1, 9, data1.length);
@@ -278,7 +278,7 @@ public class TestDConRefRecord {
      * Test of isExternalRef method, of class DConRefRecord.
      */
     @Test
-    public void testIsExternalRef() {
+    void testIsExternalRef() {
         DConRefRecord instance = new DConRefRecord(TestcaseRecordInputStream.create(81, data1));
         assertTrue(instance.isExternalRef(), "external reference");
         instance = new DConRefRecord(TestcaseRecordInputStream.create(81, data2));

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java Fri Jan  8 23:50:02 2021
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
 
 public final class TestDVALRecord {
     @Test
-    public void testRead() {
+    void testRead() {
         byte[] data = new byte[22];
         LittleEndian.putShort(data, 0, DVALRecord.sid);
         LittleEndian.putShort(data, 2, (short)18);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java Fri Jan  8 23:50:02 2021
@@ -30,7 +30,7 @@ public final class TestDrawingGroupRecor
     private static final int MAX_DATA_SIZE = MAX_RECORD_SIZE - 4;
 
     @Test
-    public void testGetRecordSize() {
+    void testGetRecordSize() {
         DrawingGroupRecord r = new DrawingGroupRecord();
         assertEquals(4, r.getRecordSize());
 
@@ -67,7 +67,7 @@ public final class TestDrawingGroupRecor
     }
 
     @Test
-    public void testSerialize() {
+    void testSerialize() {
         // Check under max record size
         DrawingGroupRecord r = new DrawingGroupRecord();
         byte[] rawData = new byte[100];
@@ -118,7 +118,7 @@ public final class TestDrawingGroupRecor
     }
 
     @Test
-    public void testGrossSizeFromDataSize() {
+    void testGrossSizeFromDataSize() {
         assertEquals( 4, DrawingGroupRecord.grossSizeFromDataSize( 0 ) );
         assertEquals( 5, DrawingGroupRecord.grossSizeFromDataSize( 1 ) );
         assertEquals( MAX_RECORD_SIZE, DrawingGroupRecord.grossSizeFromDataSize( MAX_DATA_SIZE ) );

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java Fri Jan  8 23:50:02 2021
@@ -36,7 +36,7 @@ public final class TestDrawingRecord {
      * See Bugzilla #47548
      */
     @Test
-    public void testReadContinued() throws IOException {
+    void testReadContinued() throws IOException {
 
         //simulate a continues drawing record
         ByteArrayOutputStream out = new ByteArrayOutputStream();

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java Fri Jan  8 23:50:02 2021
@@ -33,7 +33,7 @@ public final class TestEmbeddedObjectRef
 	private static final short EORSR_SID = EmbeddedObjectRefSubRecord.sid;
 
 	@Test
-	public void testStore() {
+	void testStore() {
 		String data1
 				= "20 00 05 00 FC 10 76 01 02 24 14 DF 00 03 10 00 "
 				+ "00 46 6F 72 6D 73 2E 43 68 65 63 6B 42 6F 78 2E "
@@ -58,7 +58,7 @@ public final class TestEmbeddedObjectRef
 	}
 
 	@Test
-	public void testCreate() {
+	void testCreate() {
 		EmbeddedObjectRefSubRecord record1 = new EmbeddedObjectRefSubRecord();
 
 		byte[] ser = record1.serialize();
@@ -74,7 +74,7 @@ public final class TestEmbeddedObjectRef
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testCameraTool_bug45912() {
+	void testCameraTool_bug45912() {
 		/*
 		 * taken from ftPictFmla sub-record in attachment 22645 (offset 0x40AB).
 		 */
@@ -98,7 +98,7 @@ public final class TestEmbeddedObjectRef
 	 */
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testVarious() {
+	void testVarious() {
 		String[] rawData = {
 			"12 00 0B 00 70 95 0B 05 3B 01 00 36 00 40 00 18 00 19 00 18",
 			"12 00 0B 00 B0 4D 3E 03 3B 00 00 00 00 01 00 00 80 01 C0 00",
@@ -132,7 +132,7 @@ public final class TestEmbeddedObjectRef
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testVisioDrawing_bug46199() {
+	void testVisioDrawing_bug46199() {
 		/*
 		 * taken from ftPictFmla sub-record in attachment 22860 (stream offset 0x768F).<br>
 		 * Note that the since the string length is zero, there is no unicode flag byte

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java Fri Jan  8 23:50:02 2021
@@ -30,13 +30,13 @@ public final class TestEndSubRecord {
     private static final byte[] data =  { };
 
     @Test
-    public void testLoad() {
+    void testLoad() {
         EndSubRecord record = new EndSubRecord(TestcaseRecordInputStream.create(0x00, data), 0);
         assertEquals(0, record.getDataSize());
     }
 
     @Test
-    public void testStore() {
+    void testStore() {
         EndSubRecord record = new EndSubRecord();
         byte [] recordBytes = record.serialize();
         assertEquals(0, recordBytes.length - 4);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java Fri Jan  8 23:50:02 2021
@@ -37,7 +37,7 @@ public final class TestEscherAggregate {
      * Tests that the create aggregate method correctly rejoins escher records together.
      */
     @Test
-    public void testCreateAggregate() {
+    void testCreateAggregate() {
         String msoDrawingRecord1 =
                 "0F 00 02 F0 20 01 00 00 10 00 08 F0 08 00 00 00 \n" +
                 "03 00 00 00 02 04 00 00 0F 00 03 F0 08 01 00 00 \n" +
@@ -85,7 +85,7 @@ public final class TestEscherAggregate {
     }
 
     @Test
-    public void testSerialize() {
+    void testSerialize() {
 
         EscherContainerRecord container1 = new EscherContainerRecord();
         EscherContainerRecord spContainer1 = new EscherContainerRecord();

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java Fri Jan  8 23:50:02 2021
@@ -32,7 +32,7 @@ public final class TestExtSSTRecord {
      *  ExtSSTRecord can be continued. Ensure we properly read the continue remainder.
      */
     @Test
-    public void test50967() throws IOException {
+    void test50967() throws IOException {
         // hex dump from ISBN_UPD_PL_20100104_1525.xls attached to Bugzilla 50867
         byte[] bytes = RawDataUtil.decompress("H4sIAAAAAAAAACWaBbAVxxZF9/jgrkFDcAvu7hrc3d3dLbhrgBDcXR8OwV2CEz" +
           "RIIFhw+4G/Zqiiqrn3zkyvvc/p7tM976sSp/CVOJIUVVJH2sa022lX0e6OLK0zpE9RpKemdCQav9lSlhhSCldqEEuq7EsbYkuLuGdJHG" +

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java Fri Jan  8 23:50:02 2021
@@ -41,7 +41,7 @@ public final class TestExtendedFormatRec
 	}
 
 	@Test
-	public void testLoad() {
+	void testLoad() {
 		ExtendedFormatRecord record = createEFR();
 		assertEquals(0, record.getFontIndex());
 		assertEquals(0, record.getFormatIndex());
@@ -59,7 +59,7 @@ public final class TestExtendedFormatRec
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testStore() {
+	void testStore() {
 //    .fontindex       = 0
 //    .formatindex     = 0
 //    .celloptions     = fffffff5
@@ -125,7 +125,7 @@ public final class TestExtendedFormatRec
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testCloneOnto() {
+	void testCloneOnto() {
 		ExtendedFormatRecord base = createEFR();
 
 		ExtendedFormatRecord other = new ExtendedFormatRecord();
@@ -136,7 +136,7 @@ public final class TestExtendedFormatRec
 	}
 
 	@Test
-	public void testRotation() {
+	void testRotation() {
         ExtendedFormatRecord record = createEFR();
         assertEquals(0, record.getRotation());
 

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java Fri Jan  8 23:50:02 2021
@@ -52,7 +52,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-	public void testBasicDeserializeReserialize() {
+	void testBasicDeserializeReserialize() {
 
 		ExternalNameRecord enr = createSimpleENR(dataFDS);
 		assertEquals("FDS", enr.getText());
@@ -62,7 +62,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-	public void testBasicSize() {
+	void testBasicSize() {
 		ExternalNameRecord enr = createSimpleENR(dataFDS);
 		assertNotEquals(13, enr.getRecordSize(), "Identified bug 44695");
 		assertEquals(17, enr.getRecordSize());
@@ -71,7 +71,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-	public void testAutoStdDocName() {
+	void testAutoStdDocName() {
 
 		ExternalNameRecord enr = createSimpleENR(dataAutoDocName);
 		assertEquals("'191219AW4 Corp,[WORKOUT_PX]'", enr.getText());
@@ -86,7 +86,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-	public void testPlainName() {
+	void testPlainName() {
 
 		ExternalNameRecord enr = createSimpleENR(dataPlainName);
 		assertEquals("Rate_Date", enr.getText());
@@ -101,7 +101,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-	public void testDDELink_bug47229() {
+	void testDDELink_bug47229() {
 		/*
 		 * Hex dump read directly from text of bugzilla 47229
 		 */
@@ -126,7 +126,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-	public void testUnicodeName_bug47384() {
+	void testUnicodeName_bug47384() {
 		// data taken from bugzilla 47384 att 23830 at offset 0x13A0
 		byte[] dataUN = HexRead.readFromString(
 				"23 00 22 00" +
@@ -143,7 +143,7 @@ public final class TestExternalNameRecor
 	}
 
 	@Test
-    public void test48339() {
+    void test48339() {
         // data taken from bugzilla 48339
         byte[] data = HexRead.readFromString(
                 "23 00 09 00" +
@@ -156,7 +156,7 @@ public final class TestExternalNameRecor
     }
 
 	@Test
-    public void testNPEWithFileFrom49219() {
+    void testNPEWithFileFrom49219() {
         // the file at test-data/spreadsheet/49219.xls has ExternalNameRecords without actual data,
     	// we did handle this during reading, but failed during serializing this out, ensure it works now
         byte[] data = new byte[] {

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java Fri Jan  8 23:50:02 2021
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
  */
 public final class TestFeatRecord {
 	@Test
-	public void testWithoutFeatRecord() throws Exception {
+	void testWithoutFeatRecord() throws Exception {
 		HSSFWorkbook hssf =
 			HSSFTestDataSamples.openSampleWorkbook("46136-WithWarnings.xls");
 		InternalWorkbook wb = HSSFTestHelper.getWorkbookForTest(hssf);
@@ -91,7 +91,7 @@ public final class TestFeatRecord {
 	}
 
 	@Test
-	public void testReadFeatRecord() {
+	void testReadFeatRecord() {
 		HSSFWorkbook hssf =
 			HSSFTestDataSamples.openSampleWorkbook("46136-NoWarnings.xls");
 		InternalWorkbook wb = HSSFTestHelper.getWorkbookForTest(hssf);
@@ -183,7 +183,7 @@ public final class TestFeatRecord {
      *  cloning sheets with feat records
      */
 	@Test
-    public void testCloneSheetWithFeatRecord() throws IOException {
+    void testCloneSheetWithFeatRecord() throws IOException {
         try (HSSFWorkbook wb =
             HSSFTestDataSamples.openSampleWorkbook("46136-WithWarnings.xls")) {
 			HSSFSheet src = wb.getSheetAt(0);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java Fri Jan  8 23:50:02 2021
@@ -48,7 +48,7 @@ public final class TestFontRecord {
     };
 
     @Test
-    public void testLoad() {
+    void testLoad() {
 
         FontRecord record = new FontRecord(TestcaseRecordInputStream.create(0x31, data));
         assertEquals(0xc8, record.getFontHeight());
@@ -70,7 +70,7 @@ public final class TestFontRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testStore() {
+    void testStore() {
 //      .fontheight      = c8
 //      .attributes      = 0
 //           .italic     = false
@@ -102,7 +102,7 @@ public final class TestFontRecord {
     }
 
     @Test
-    public void testCloneOnto() {
+    void testCloneOnto() {
         FontRecord base = new FontRecord(TestcaseRecordInputStream.create(0x31, data));
 
         FontRecord other = new FontRecord();
@@ -115,7 +115,7 @@ public final class TestFontRecord {
     }
 
     @Test
-    public void testSameProperties() {
+    void testSameProperties() {
         FontRecord f1 = new FontRecord(TestcaseRecordInputStream.create(0x31, data));
         FontRecord f2 = new FontRecord(TestcaseRecordInputStream.create(0x31, data));
 
@@ -138,7 +138,7 @@ public final class TestFontRecord {
      * samples to say otherwise.
      */
     @Test
-    public void testEmptyName_bug47250() {
+    void testEmptyName_bug47250() {
         byte[] emptyNameData = HexRead.readFromString(
                 "C8 00 00 00 FF 7F 90 01 00 00 00 00 00 00 "
                 + "00" // zero length

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java Fri Jan  8 23:50:02 2021
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
 public final class TestFormulaRecord {
 
 	@Test
-	public void testCreateFormulaRecord () {
+	void testCreateFormulaRecord () {
 		FormulaRecord record = new FormulaRecord();
 		record.setColumn((short)0);
 		record.setRow(1);
@@ -52,7 +52,7 @@ public final class TestFormulaRecord {
 	 * This formula record is a representation of =1/0 at row 0, column 0
 	 */
 	@Test
-	public void testCheckNanPreserve() {
+	void testCheckNanPreserve() {
 		byte[] formulaByte = {
 			0, 0, 0, 0,
 			0x0F, 0x00,
@@ -102,7 +102,7 @@ public final class TestFormulaRecord {
 	 * Tests to see if the shared formula cells properly reserialize the expPtg
 	 */
 	@Test
-	public void testExpFormula() {
+	void testExpFormula() {
 		byte[] formulaByte = new byte[27];
 
 		formulaByte[4] =(byte)0x0F;
@@ -121,7 +121,7 @@ public final class TestFormulaRecord {
 	}
 
 	@Test
-	public void testWithConcat() {
+	void testWithConcat() {
 		// =CHOOSE(2,A2,A3,A4)
 		byte[] data = {
 				1, 0, 1, 0, 15, 0, 0, 0, 0, 0, 0, 0, 57,
@@ -159,7 +159,7 @@ public final class TestFormulaRecord {
 	}
 
 	@Test
-	public void testReserialize() {
+	void testReserialize() {
 		FormulaRecord formulaRecord = new FormulaRecord();
 		formulaRecord.setRow(1);
 		formulaRecord.setColumn((short) 1);
@@ -182,7 +182,7 @@ public final class TestFormulaRecord {
 	 * inside {@link FormulaRecord}
 	 */
 	@Test
-	public void testCachedValue_bug46479() {
+	void testCachedValue_bug46479() {
 		FormulaRecord fr0 = new FormulaRecord();
 		FormulaRecord fr1 = new FormulaRecord();
 		// test some other cached value types

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java Fri Jan  8 23:50:02 2021
@@ -34,7 +34,7 @@ public final class TestFtCblsSubRecord {
     };
 
     @Test
-    public void testRead() {
+    void testRead() {
         FtCblsSubRecord record = new FtCblsSubRecord(TestcaseRecordInputStream.create(FtCblsSubRecord.sid, data), data.length);
 
         assertEquals(FtCblsSubRecord.sid, record.getSid());
@@ -42,7 +42,7 @@ public final class TestFtCblsSubRecord {
     }
 
     @Test
-    public void testWrite() {
+    void testWrite() {
         FtCblsSubRecord record = new FtCblsSubRecord();
         assertEquals(FtCblsSubRecord.sid, record.getSid());
         assertEquals(data.length, record.getDataSize());
@@ -52,7 +52,7 @@ public final class TestFtCblsSubRecord {
     }
 
     @Test
-    public void testClone() {
+    void testClone() {
         FtCblsSubRecord record = new FtCblsSubRecord();
         byte[] src = record.serialize();
 

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java Fri Jan  8 23:50:02 2021
@@ -283,7 +283,7 @@ public final class TestHyperlinkRecord {
 	}
 
     @Test
-    public void testReadURLLink(){
+    void testReadURLLink(){
         RecordInputStream is = TestcaseRecordInputStream.create(HyperlinkRecord.sid, data1);
         HyperlinkRecord link = new HyperlinkRecord(is);
         assertEquals(2, link.getFirstRow());
@@ -303,7 +303,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testReadFileLink(){
+    void testReadFileLink(){
         RecordInputStream is = TestcaseRecordInputStream.create(HyperlinkRecord.sid, data2);
         HyperlinkRecord link = new HyperlinkRecord(is);
         assertEquals(0, link.getFirstRow());
@@ -323,7 +323,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testReadEmailLink(){
+    void testReadEmailLink(){
         RecordInputStream is = TestcaseRecordInputStream.create(HyperlinkRecord.sid, data3);
         HyperlinkRecord link = new HyperlinkRecord(is);
         assertEquals(1, link.getFirstRow());
@@ -342,7 +342,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testReadDocumentLink(){
+    void testReadDocumentLink(){
         RecordInputStream is = TestcaseRecordInputStream.create(HyperlinkRecord.sid, data4);
         HyperlinkRecord link = new HyperlinkRecord(is);
         assertEquals(3, link.getFirstRow());
@@ -372,7 +372,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testSerialize(){
+    void testSerialize(){
         serialize(data1);
         serialize(data2);
         serialize(data3);
@@ -380,7 +380,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testCreateURLRecord() {
+    void testCreateURLRecord() {
         HyperlinkRecord link = new HyperlinkRecord();
         link.newUrlLink();
         link.setFirstRow((short)2);
@@ -395,7 +395,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testCreateFileRecord() {
+    void testCreateFileRecord() {
         HyperlinkRecord link = new HyperlinkRecord();
         link.newFileLink();
         link.setFirstRow((short)0);
@@ -410,7 +410,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testCreateDocumentRecord() {
+    void testCreateDocumentRecord() {
         HyperlinkRecord link = new HyperlinkRecord();
         link.newDocumentLink();
         link.setFirstRow((short)3);
@@ -425,7 +425,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testCreateEmailtRecord() {
+    void testCreateEmailtRecord() {
         HyperlinkRecord link = new HyperlinkRecord();
         link.newUrlLink();
         link.setFirstRow((short)1);
@@ -440,7 +440,7 @@ public final class TestHyperlinkRecord {
     }
 
     @Test
-    public void testClone() {
+    void testClone() {
         byte[][] data = {data1, data2, data3, data4};
         for (final byte[] d : data) {
             RecordInputStream is = TestcaseRecordInputStream.create(HyperlinkRecord.sid, d);
@@ -453,7 +453,7 @@ public final class TestHyperlinkRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testReserializeTargetFrame() {
+    void testReserializeTargetFrame() {
 		RecordInputStream in = TestcaseRecordInputStream.create(HyperlinkRecord.sid, dataTargetFrame);
 		HyperlinkRecord hr = new HyperlinkRecord(in);
 		byte[] ser = hr.serialize();
@@ -461,7 +461,7 @@ public final class TestHyperlinkRecord {
 	}
 
     @Test
-	public void testReserializeLinkToWorkbook() {
+	void testReserializeLinkToWorkbook() {
 
 		RecordInputStream in = TestcaseRecordInputStream.create(HyperlinkRecord.sid, dataLinkToWorkbook);
 		HyperlinkRecord hr = new HyperlinkRecord(in);
@@ -472,7 +472,7 @@ public final class TestHyperlinkRecord {
 	}
 
     @Test
-    public void testReserializeUNC() {
+    void testReserializeUNC() {
 
 		RecordInputStream in = TestcaseRecordInputStream.create(HyperlinkRecord.sid, dataUNC);
 		HyperlinkRecord hr = new HyperlinkRecord(in);
@@ -482,7 +482,7 @@ public final class TestHyperlinkRecord {
 	}
 
     @Test
-	public void testGUID() throws IOException {
+	void testGUID() throws IOException {
 		ClassID g;
 		g = new ClassID("3F2504E0-4F89-11D3-9A0C-0305E82C3301");
 		confirmGUID(g, 0x3F2504E0, 0x4F89, 0x11D3, 0x9A0C0305E82C3301L);
@@ -522,7 +522,7 @@ public final class TestHyperlinkRecord {
 	}
 
 	@Test
-    public void test47498(){
+    void test47498(){
         RecordInputStream is = TestcaseRecordInputStream.create(HyperlinkRecord.sid, data_47498);
         HyperlinkRecord link = new HyperlinkRecord(is);
         assertEquals(2, link.getFirstRow());

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java Fri Jan  8 23:50:02 2021
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
 public final class TestInterfaceEndRecord {
 
     @Test
-    public void testCreate() {
+    void testCreate() {
         InterfaceEndRecord record = InterfaceEndRecord.instance;
         assertEquals(0, record.getDataSize());
     }
@@ -46,7 +46,7 @@ public final class TestInterfaceEndRecor
      * data to an {@link InterfaceHdrRecord}.
      */
     @Test
-    public void testUnexpectedBytes_bug47251(){
+    void testUnexpectedBytes_bug47251(){
         String hex = "" +
                 "09 08 10 00 00 06 05 00 EC 15 CD 07 C1 C0 00 00 06 03 00 00 " +   //BOF
                 "E2 00 02 00 B0 04 " + //INTERFACEEND with extra two bytes

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java Fri Jan  8 23:50:02 2021
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
 public final class TestLabelRecord  {
 
 	@Test
-	public void testEmptyString() throws IOException {
+	void testEmptyString() throws IOException {
 		try (HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("ex42570-20305.xls");
 			 HSSFWorkbook wb2 = HSSFTestDataSamples.writeOutAndReadBack(wb1)) {
 			HSSFSheet s1 = wb1.getSheetAt(0);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java Fri Jan  8 23:50:02 2021
@@ -45,7 +45,7 @@ public final class TestLbsDataSubRecord
      * test data was taken from 47701.xls
      */
     @Test
-    public void test_47701(){
+    void test_47701(){
         byte[] data = HexRead.readFromString(
                         "15, 00, 12, 00, 12, 00, 02, 00, 11, 20, " +
                         "00, 00, 00, 00, 80, 3D, 03, 05, 00, 00, " +
@@ -79,7 +79,7 @@ public final class TestLbsDataSubRecord
      * test data was taken from the file attached to Bugzilla 45778
      */
     @Test
-    public void test_45778(){
+    void test_45778(){
         byte[] data = HexRead.readFromString(
                                 "15, 00, 12, 00, 14, 00, 01, 00, 01, 00, " +
                                 "01, 21, 00, 00, 3C, 13, F4, 03, 00, 00, " +
@@ -119,7 +119,7 @@ public final class TestLbsDataSubRecord
      * There are 5 padding bytes that are removed by POI
      */
     @Test
-    public void test_remove_padding(){
+    void test_remove_padding(){
         byte[] data = HexRead.readFromString(
                         "5D, 00, 4C, 00, " +
                         "15, 00, 12, 00, 12, 00, 01, 00, 11, 00, " +
@@ -153,7 +153,7 @@ public final class TestLbsDataSubRecord
     }
 
     @Test
-    public void test_LbsDropData() throws IOException{
+    void test_LbsDropData() throws IOException{
         byte[] data = HexRead.readFromString(
                                  //LbsDropData
                                  "0A, 00, " + //flags

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java Fri Jan  8 23:50:02 2021
@@ -41,7 +41,7 @@ public final class TestMergeCellsRecord
 	 * Make sure when a clone is called, we actually clone it.
 	 */
 	@Test
-	public void testCloneReferences() {
+	void testCloneReferences() {
 		CellRangeAddress[] cras = { new CellRangeAddress(0, 1, 0, 2), };
 		MergeCellsRecord merge = new MergeCellsRecord(cras, 0, cras.length);
 		MergeCellsRecord clone = merge.copy();
@@ -60,7 +60,7 @@ public final class TestMergeCellsRecord
 	}
 
 	@Test
-	public void testMCTable_bug46009() {
+	void testMCTable_bug46009() {
 		MergedCellsTable mct = new MergedCellsTable();
 		CellRangeAddress[] cras = { new CellRangeAddress(0, 0, 0, 3) };
 		MergeCellsRecord mcr1 = new MergeCellsRecord(cras, 0, 1);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java Fri Jan  8 23:50:02 2021
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
  */
 public final class TestNameCommentRecord {
 	@Test
-	public void testReserialize() {
+	void testReserialize() {
 		final byte[] data = HexRead
 				.readFromString(""
 						+ "94 08 00 00 00 00 00 00 00 00 00 00 04 00 07 00 00 6E 61 6D 65 00 63 6F 6D 6D 65 6E 74]");

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java Fri Jan  8 23:50:02 2021
@@ -45,7 +45,7 @@ public final class TestNameRecord {
 	 * Makes sure that additional name information is parsed properly such as menu/description
 	 */
 	@Test
-	public void testFillExtras() {
+	void testFillExtras() {
 
 		byte[] examples = HexRead.readFromString(""
 				+ "88 03 67 06 07 00 00 00 00 00 00 23 00 00 00 4D "
@@ -60,7 +60,7 @@ public final class TestNameRecord {
 	}
 
 	@Test
-	public void testReserialize() {
+	void testReserialize() {
 		byte[] data = HexRead
 				.readFromString(""
 						+ "20 00 00 01 0B 00 00 00 01 00 00 00 00 00 00 06 3B 00 00 00 00 02 00 00 00 09 00]");
@@ -72,7 +72,7 @@ public final class TestNameRecord {
 	}
 
 	@Test
-	public void testFormulaRelAbs_bug46174() throws IOException {
+	void testFormulaRelAbs_bug46174() throws IOException {
 		// perhaps this testcase belongs on TestHSSFName
 		try (HSSFWorkbook wb = new HSSFWorkbook()) {
 			HSSFName name = wb.createName();
@@ -85,7 +85,7 @@ public final class TestNameRecord {
 	}
 
 	@Test
-	public void testFormulaGeneral() throws IOException {
+	void testFormulaGeneral() throws IOException {
 		// perhaps this testcase belongs on TestHSSFName
 		HSSFWorkbook wb = new HSSFWorkbook();
 		HSSFName name = wb.createName();
@@ -103,7 +103,7 @@ public final class TestNameRecord {
      *  A NameRecord followed by a ContinueRecord. See Bugzilla 50244
      */
 	@Test
-    public void test50244() throws IOException {
+    void test50244() throws IOException {
         byte[] data1 = RawDataUtil.decompress(
 			"H4sIAAAAAAAAAI3Zu2qWQRAA0I8EQcHGzkrwBcLO7B0sBR9AwdYIKdKFoPhovp7xLyQWyX+m2OWw7TIX5u3x/t1xHG9ePhyXxyl+" +
 			"fbz+cf3p/ufd3c3nm/vbm6tvx++L18fXy4fr4tVxxNWXLFelhCENlRCIZuiERAzDJFTEMmxCM/RiCMJApKESJqIZOmEhhmESNmIZ" +
@@ -139,7 +139,7 @@ public final class TestNameRecord {
     }
 
 	@Test
-    public void testBug57923() {
+    void testBug57923() {
         NameRecord record = new NameRecord();
         assertEquals(0, record.getExternSheetNumber());
 

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java Fri Jan  8 23:50:02 2021
@@ -41,7 +41,7 @@ public final class TestNoteRecord {
             );
 
     @Test
-    public void testRead() {
+    void testRead() {
 
         NoteRecord record = new NoteRecord(TestcaseRecordInputStream.create(NoteRecord.sid, testData));
 
@@ -54,7 +54,7 @@ public final class TestNoteRecord {
     }
 
     @Test
-    public void testWrite() {
+    void testWrite() {
         NoteRecord record = new NoteRecord();
         assertEquals(NoteRecord.sid, record.getSid());
 
@@ -69,7 +69,7 @@ public final class TestNoteRecord {
     }
 
     @Test
-    public void testClone() {
+    void testClone() {
         NoteRecord record = new NoteRecord();
 
         record.setRow((short)1);
@@ -92,7 +92,7 @@ public final class TestNoteRecord {
     }
 
     @Test
-    public void testUnicodeAuthor() {
+    void testUnicodeAuthor() {
         // This sample data was created by setting the 'user name' field in the 'Personalize'
         // section of Excel's options to \u30A2\u30D1\u30C3\u30C1\u65CF, and then
         // creating a cell comment.

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java Fri Jan  8 23:50:02 2021
@@ -36,7 +36,7 @@ public final class TestNoteStructureSubR
     };
 
     @Test
-    public void testRead() {
+    void testRead() {
         NoteStructureSubRecord record = new NoteStructureSubRecord(TestcaseRecordInputStream.create(NoteStructureSubRecord.sid, data), data.length);
 
         assertEquals(NoteStructureSubRecord.sid, record.getSid());
@@ -44,7 +44,7 @@ public final class TestNoteStructureSubR
     }
 
     @Test
-    public void testWrite() {
+    void testWrite() {
         NoteStructureSubRecord record = new NoteStructureSubRecord();
         assertEquals(NoteStructureSubRecord.sid, record.getSid());
         assertEquals(data.length, record.getDataSize());
@@ -54,7 +54,7 @@ public final class TestNoteStructureSubR
     }
 
     @Test
-    public void testClone() {
+    void testClone() {
         NoteStructureSubRecord record = new NoteStructureSubRecord();
         byte[] src = record.serialize();
 

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java Fri Jan  8 23:50:02 2021
@@ -60,7 +60,7 @@ public final class TestObjRecord {
     );
 
     @Test
-    public void testLoad() {
+    void testLoad() {
         ObjRecord record = new ObjRecord(TestcaseRecordInputStream.create(ObjRecord.sid, recdata));
 
         assertEquals(26, record.getRecordSize() - 4);
@@ -73,7 +73,7 @@ public final class TestObjRecord {
     }
 
     @Test
-    public void testStore() {
+    void testStore() {
         ObjRecord record = new ObjRecord(TestcaseRecordInputStream.create(ObjRecord.sid, recdata));
 
         byte [] recordBytes = record.serialize();
@@ -83,7 +83,7 @@ public final class TestObjRecord {
     }
 
     @Test
-    public void testConstruct() {
+    void testConstruct() {
         ObjRecord record = new ObjRecord();
         CommonObjectDataSubRecord ftCmo = new CommonObjectDataSubRecord();
         ftCmo.setObjectType( CommonObjectDataSubRecord.OBJECT_TYPE_COMMENT);
@@ -109,7 +109,7 @@ public final class TestObjRecord {
     }
 
     @Test
-    public void testReadWriteWithPadding_bug45133() {
+    void testReadWriteWithPadding_bug45133() {
         ObjRecord record = new ObjRecord(TestcaseRecordInputStream.create(recdataNeedingPadding));
         assertNotEquals(34, record.getRecordSize(), "Identified bug 45133");
         assertEquals(36, record.getRecordSize());
@@ -127,7 +127,7 @@ public final class TestObjRecord {
      */
     @SuppressWarnings("squid:S2699")
     @Test
-    public void test4BytePadding() {
+    void test4BytePadding() {
         // actual data from file saved by Excel 2007
         byte[] data = HexRead.readFromString(""
                 + "15 00 12 00  1E 00 01 00  11 60 B4 6D  3C 01 C4 06 "

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java Fri Jan  8 23:50:02 2021
@@ -42,7 +42,7 @@ public final class TestPLVRecord {
     private final static String SHEET_NAME = "S2";
 
     @Test
-    public void testPLVRecord() throws Exception {
+    void testPLVRecord() throws Exception {
         try (InputStream is = HSSFTestDataSamples.openSampleFileStream(XLS_FILENAME);
              HSSFWorkbook workbook = new HSSFWorkbook(is)) {
 

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java Fri Jan  8 23:50:02 2021
@@ -35,7 +35,7 @@ public final class TestPaletteRecord {
      * Tests that the default palette matches the constants of HSSFColor
      */
     @Test
-    public void testDefaultPalette() {
+    void testDefaultPalette() {
         PaletteRecord palette = new PaletteRecord();
 
         //make sure all the HSSFColor constants match

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java Fri Jan  8 23:50:02 2021
@@ -38,7 +38,7 @@ public final class TestPaneRecord {
     };
 
     @Test
-    public void testLoad() {
+    void testLoad() {
         PaneRecord record = new PaneRecord(TestcaseRecordInputStream.create(0x41, data));
 
         assertEquals( (short)1, record.getX());
@@ -52,7 +52,7 @@ public final class TestPaneRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testStore() {
+    void testStore() {
         PaneRecord record = new PaneRecord();
 
         record.setX( (short) 1);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java Fri Jan  8 23:50:02 2021
@@ -35,7 +35,7 @@ public final class TestRecalcIdRecord {
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-	public void testBasicDeserializeReserialize() {
+	void testBasicDeserializeReserialize() {
 
 		byte[] data = HexRead.readFromString(
 				"C1 01" +  // rt
@@ -47,7 +47,7 @@ public final class TestRecalcIdRecord {
 	}
 
 	@Test
-	public void testBadFirstField_bug48096() {
+	void testBadFirstField_bug48096() {
 		/*
 		 * Data taken from the sample file referenced in Bugzilla 48096, file offset 0x0D45.
 		 * The apparent problem is that the first data short field has been written with the

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java Fri Jan  8 23:50:02 2021
@@ -44,7 +44,7 @@ public final class TestRecordFactory {
 	 *
 	 */
     @Test
-	public void testBasicRecordConstruction() {
+	void testBasicRecordConstruction() {
 		short recType = BOFRecord.sid;
 		byte[]   data	= {
 			0, 6, 5, 0, -2, 28, -51, 7, -55, 64, 0, 0, 6, 1, 0, 0
@@ -87,7 +87,7 @@ public final class TestRecordFactory {
 	 *
 	 */
     @Test
-    public void testSpecial() {
+    void testSpecial() {
 		short recType = RKRecord.sid;
 		byte[] data = {
 			0, 0, 0, 0, 21, 0, 0, 0, 0, 0
@@ -114,7 +114,7 @@ public final class TestRecordFactory {
 	 * FAILURE:	The wrong records are created or contain the wrong values <P>
 	 */
     @Test
-	public void testContinuedUnknownRecord() {
+	void testContinuedUnknownRecord() {
 		byte[] data = {
 			0, -1, 0, 0, // an unknown record with 0 length
 			0x3C , 0, 3, 0, 1, 2, 3, // a continuation record with 3 bytes of data
@@ -144,7 +144,7 @@ public final class TestRecordFactory {
 	 * Record factory must preserve this structure when reading records.
 	 */
     @Test
-	public void testMixedContinue() throws IOException {
+	void testMixedContinue() throws IOException {
 		// Adapted from a real test sample file 39512.xls (Offset 0x4854).
 		// See Bug 39512 for details.
 		String dump =
@@ -194,7 +194,7 @@ public final class TestRecordFactory {
 	}
 
     @Test
-	public void testNonZeroPadding_bug46987() throws IOException {
+	void testNonZeroPadding_bug46987() throws IOException {
 		Record[] recs = {
 			new BOFRecord(),
 			new WriteAccessRecord(), // need *something* between BOF and EOF

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java Fri Jan  8 23:50:02 2021
@@ -55,7 +55,7 @@ public final class TestRecordInputStream
 
 
 	@Test
-	public void testChangeOfCompressionFlag_bug25866() {
+	void testChangeOfCompressionFlag_bug25866() {
 		byte[] changingFlagSimpleData = HexRead.readFromString(""
 				+ "AA AA "  // fake SID
 				+ "06 00 "  // first rec len 6
@@ -69,7 +69,7 @@ public final class TestRecordInputStream
 	}
 
 	@Test
-	public void testChangeFromUnCompressedToCompressed() {
+	void testChangeFromUnCompressedToCompressed() {
 		byte[] changingFlagSimpleData = HexRead.readFromString(""
 				+ "AA AA "  // fake SID
 				+ "0F 00 "  // first rec len 15
@@ -81,7 +81,7 @@ public final class TestRecordInputStream
 	}
 
 	@Test
-	public void testReadString() {
+	void testReadString() {
 		byte[] changingFlagFullData = HexRead.readFromString(""
 				+ "AA AA "  // fake SID
 				+ "12 00 "  // first rec len 18 (15 + next 3 bytes)
@@ -96,7 +96,7 @@ public final class TestRecordInputStream
 
 	@ParameterizedTest
 	@CsvSource({"1, 200", "0, 200", "999999999, 200", HeaderRecord.sid+", 200"})
-	public void testLeftoverDataException(int sid, int remainingByteCount) {
+	void testLeftoverDataException(int sid, int remainingByteCount) {
 	    // just ensure that the exception is created correctly, even with unknown sids
 		assertDoesNotThrow(() -> new RecordInputStream.LeftoverDataException(sid, remainingByteCount));
 	}

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java Fri Jan  8 23:50:02 2021
@@ -34,7 +34,7 @@ public final class TestSCLRecord {
     };
 
     @Test
-    public void testLoad() {
+    void testLoad() {
         SCLRecord record = new SCLRecord(TestcaseRecordInputStream.create(0xa0, data));
         assertEquals( 3, record.getNumerator());
         assertEquals( 4, record.getDenominator());
@@ -44,7 +44,7 @@ public final class TestSCLRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testStore() {
+    void testStore() {
         SCLRecord record = new SCLRecord();
         record.setNumerator( (short)3 );
         record.setDenominator( (short)4 );

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java Fri Jan  8 23:50:02 2021
@@ -53,7 +53,7 @@ public final class TestSSTDeserializer {
     }
 
     @Test
-    public void testSpanRichTextToPlainText() throws IOException {
+    void testSpanRichTextToPlainText() throws IOException {
         byte[] header = readSampleHexData("richtextdata.txt", "header", FAKE_SID);
         byte[] continueBytes = readSampleHexData("richtextdata.txt", "continue1", ContinueRecord.sid);
         RecordInputStream in = TestcaseRecordInputStream.create(concat(header, continueBytes));
@@ -67,7 +67,7 @@ public final class TestSSTDeserializer {
     }
 
     @Test
-    public void testContinuationWithNoOverlap() throws IOException {
+    void testContinuationWithNoOverlap() throws IOException {
         byte[] header = readSampleHexData("evencontinuation.txt", "header", FAKE_SID);
         byte[] continueBytes = readSampleHexData("evencontinuation.txt", "continue1", ContinueRecord.sid);
         RecordInputStream in = TestcaseRecordInputStream.create(concat(header, continueBytes));
@@ -84,7 +84,7 @@ public final class TestSSTDeserializer {
      * Strings can actually span across more than one continuation.
      */
     @Test
-    public void testStringAcross2Continuations() throws IOException {
+    void testStringAcross2Continuations() throws IOException {
         byte[] header = readSampleHexData("stringacross2continuations.txt", "header", FAKE_SID);
         byte[] continue1 = readSampleHexData("stringacross2continuations.txt", "continue1", ContinueRecord.sid);
         byte[] continue2 = readSampleHexData("stringacross2continuations.txt", "continue2", ContinueRecord.sid);
@@ -100,7 +100,7 @@ public final class TestSSTDeserializer {
     }
 
     @Test
-    public void testExtendedStrings() throws IOException {
+    void testExtendedStrings() throws IOException {
         byte[] header = readSampleHexData("extendedtextstrings.txt", "rich-header", FAKE_SID);
         byte[] continueBytes = readSampleHexData("extendedtextstrings.txt", "rich-continue1", ContinueRecord.sid);
         RecordInputStream in = TestcaseRecordInputStream.create(concat(header, continueBytes));

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java Fri Jan  8 23:50:02 2021
@@ -83,7 +83,7 @@ public final class TestSSTRecord {
      * SST is often split over several {@link ContinueRecord}s
      */
     @Test
-    public void testContinuedRecord() throws IOException {
+    void testContinuedRecord() throws IOException {
         byte[] origData;
         SSTRecord record;
         byte[] ser_output;
@@ -125,7 +125,7 @@ public final class TestSSTRecord {
      * Test capability of handling mondo big strings
      */
     @Test
-    public void testHugeStrings() {
+    void testHugeStrings() {
         SSTRecord record = new SSTRecord();
         byte[][] bstrings =
                 {
@@ -208,7 +208,7 @@ public final class TestSSTRecord {
      * test SSTRecord boundary conditions
      */
     @Test
-    public void testSSTRecordBug() {
+    void testSSTRecordBug() {
         // create an SSTRecord and write a certain pattern of strings
         // to it ... then serialize it and verify the content
         SSTRecord record = new SSTRecord();
@@ -244,7 +244,7 @@ public final class TestSSTRecord {
      * test simple addString
      */
     @Test
-    public void testSimpleAddString() {
+    void testSimpleAddString() {
         SSTRecord record = new SSTRecord();
         UnicodeString s1 = new UnicodeString("Hello world");
 
@@ -290,7 +290,7 @@ public final class TestSSTRecord {
      * test simple constructor
      */
     @Test
-    public void testSimpleConstructor() {
+    void testSimpleConstructor() {
         SSTRecord record = new SSTRecord();
 
         assertEquals( 0, record.getNumStrings() );
@@ -310,7 +310,7 @@ public final class TestSSTRecord {
      * Tests that workbooks with rich text that duplicates a non rich text cell can be read and written.
      */
     @Test
-    public void testReadWriteDuplicatedRichText1() throws Exception {
+    void testReadWriteDuplicatedRichText1() throws Exception {
         try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("duprich1.xls")) {
             HSSFSheet sheet = wb.getSheetAt(1);
             assertEquals("01/05 (Wed)", sheet.getRow(0).getCell(8).getStringCellValue());
@@ -351,7 +351,7 @@ public final class TestSSTRecord {
     }
 
     @Test
-    public void test50779_1() throws IOException {
+    void test50779_1() throws IOException {
         byte[] bytes = RawDataUtil.decompress("H4sIAAAAAAAAAL3aO2gVQRQG4HO5XkEZ8AESi4DBKoXFP+8IVioSvahcLxKC" +
           "iRIRc9FEUZExCL4IYnyQqIi9SEATFUHRTkSQaBFsrEQLG8EiFgGrCM6uIGiff5c5e3ZY9l8W9mt2FqSjoyEixTBSW5kPm7EV29CNHa" +
           "hjJ3ajgSb2oge92Id+HMAADuEwWjiCoxjCMI7hOE7iNM7gLM7hPC7gIi5hFJdxBWO4imu4jhsYxy3cBqTYtVRESU28/NnqMFJZ/Fgj" +
@@ -378,7 +378,7 @@ public final class TestSSTRecord {
     }
 
     @Test
-    public void test50779_2() throws IOException {
+    void test50779_2() throws IOException {
         byte[] bytes = RawDataUtil.decompress("H4sIAAAAAAAAAL3Uu2sVQRjG4e9wOKKw4gUkKSyCVQqLd2d2ZhOwiiLqQSUe" +
           "JIgRUcQc1ERUZBXBG0GMFxIiaC8S8I6FWIoIop2NlWBhI1hoIVhFcM6Cgn+Avx3m2+HbXd5hYJ9FGxgYNbPedNYY0SZt1hZtU1vbtV" +
           "Oj6mi3xrRHe7VP+3VAh3RYXR3RUR3TpKZ0XCd1Wmd0Tud1QRd1SZc1rSu6qhld03Xd0E3Nal63JOuNnIlxTIxnYgomJjAxkYkpmZgh" +
@@ -404,7 +404,7 @@ public final class TestSSTRecord {
     }
 
     @Test
-    public void test57456() {
+    void test57456() {
         byte[] bytes = HexRead.readFromString("FC, 00, 08, 00, 00, 00, 00, 00, E1, 06, 00, 00");
         RecordInputStream in = TestcaseRecordInputStream.create(bytes);
         assertEquals(SSTRecord.sid, in.getSid());

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java Fri Jan  8 23:50:02 2021
@@ -54,7 +54,7 @@ public final class TestSSTRecordSizeCalc
 	}
 
 	@Test
-	public void testBasic() {
+	void testBasic() {
 		strings.add(makeUnicodeString(SMALL_STRING));
 		confirmSize(SST_RECORD_OVERHEAD
 				+ COMPRESSED_PLAIN_STRING_OVERHEAD
@@ -62,7 +62,7 @@ public final class TestSSTRecordSizeCalc
 	}
 
 	@Test
-	public void testBigStringAcrossUnicode() {
+	void testBigStringAcrossUnicode() {
 		int bigString = MAX_DATA_SPACE + 100;
 		strings.add(makeUnicodeString(bigString));
 		confirmSize(SST_RECORD_OVERHEAD
@@ -74,7 +74,7 @@ public final class TestSSTRecordSizeCalc
 	}
 
 	@Test
-	public void testPerfectFit() {
+	void testPerfectFit() {
 		int perfectFit = MAX_DATA_SPACE - COMPRESSED_PLAIN_STRING_OVERHEAD;
 		strings.add(makeUnicodeString(perfectFit));
 		confirmSize(SST_RECORD_OVERHEAD
@@ -83,7 +83,7 @@ public final class TestSSTRecordSizeCalc
 	}
 
 	@Test
-	public void testJustOversized() {
+	void testJustOversized() {
 		int tooBig = MAX_DATA_SPACE - COMPRESSED_PLAIN_STRING_OVERHEAD + 1;
 		strings.add(makeUnicodeString(tooBig));
 		confirmSize(SST_RECORD_OVERHEAD
@@ -96,7 +96,7 @@ public final class TestSSTRecordSizeCalc
 	}
 
 	@Test
-	public void testSecondStringStartsOnNewContinuation() {
+	void testSecondStringStartsOnNewContinuation() {
 		int perfectFit = MAX_DATA_SPACE - COMPRESSED_PLAIN_STRING_OVERHEAD;
 		strings.add(makeUnicodeString(perfectFit));
 		strings.add(makeUnicodeString(SMALL_STRING));
@@ -109,7 +109,7 @@ public final class TestSSTRecordSizeCalc
 	}
 
 	@Test
-	public void testHeaderCrossesNormalContinuePoint() {
+	void testHeaderCrossesNormalContinuePoint() {
 		int almostPerfectFit = MAX_DATA_SPACE - COMPRESSED_PLAIN_STRING_OVERHEAD - 2;
 		strings.add(makeUnicodeString(almostPerfectFit));
 		String oneCharString = new String(new char[1]);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java Fri Jan  8 23:50:02 2021
@@ -76,7 +76,7 @@ public final class TestSharedFormulaReco
      * incorrect encoding.  The formula here is one such example (Excel displays #VALUE!).
      */
     @Test
-    public void testConvertSharedFormulasOperandClasses_bug45123() {
+    void testConvertSharedFormulasOperandClasses_bug45123() {
 
         LittleEndianInput in = TestcaseRecordInputStream.createLittleEndian(SHARED_FORMULA_WITH_REF_ARRAYS_DATA);
         int encodedLen = in.readUShort();
@@ -98,7 +98,7 @@ public final class TestSharedFormulaReco
     }
 
     @Test
-    public void testConvertSharedFormulas() {
+    void testConvertSharedFormulas() {
         HSSFWorkbook wb = new HSSFWorkbook();
         HSSFEvaluationWorkbook fpb = HSSFEvaluationWorkbook.create(wb);
         Ptg[] sharedFormula, convertedFormula;
@@ -139,7 +139,7 @@ public final class TestSharedFormulaReco
      * Make sure that POI preserves {@link SharedFormulaRecord}s
      */
     @Test
-    public void testPreserveOnReserialize() {
+    void testPreserveOnReserialize() {
         HSSFWorkbook wb;
         HSSFSheet sheet;
         HSSFCell cellB32769;
@@ -172,7 +172,7 @@ public final class TestSharedFormulaReco
     }
 
     @Test
-    public void testUnshareFormulaDueToChangeFormula() {
+    void testUnshareFormulaDueToChangeFormula() {
         HSSFWorkbook wb;
         HSSFSheet sheet;
         HSSFCell cellB32769;
@@ -194,7 +194,7 @@ public final class TestSharedFormulaReco
     }
 
     @Test
-    public void testUnshareFormulaDueToDelete() {
+    void testUnshareFormulaDueToDelete() {
         HSSFWorkbook wb;
         HSSFSheet sheet;
         HSSFCell cell;

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java Fri Jan  8 23:50:02 2021
@@ -43,7 +43,7 @@ public final class TestStringRecord {
 	);
 
 	@Test
-	public void testLoad() {
+	void testLoad() {
 
 		StringRecord record = new StringRecord(TestcaseRecordInputStream.create(0x207, data));
 		assertEquals( "Fahrzeugtyp", record.getString());
@@ -52,7 +52,7 @@ public final class TestStringRecord {
 	}
 
 	@Test
-    public void testStore() {
+    void testStore() {
 		StringRecord record = new StringRecord();
 		record.setString("Fahrzeugtyp");
 
@@ -64,7 +64,7 @@ public final class TestStringRecord {
 	}
 
 	@Test
-    public void testContinue() throws IOException {
+    void testContinue() throws IOException {
 		int MAX_BIFF_DATA = RecordInputStream.MAX_RECORD_DATA_SIZE;
 		int TEXT_LEN = MAX_BIFF_DATA + 1000; // deliberately over-size
 		String textChunk = "ABCDEGGHIJKLMNOP"; // 16 chars

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java Fri Jan  8 23:50:02 2021
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
  */
 public final class TestStyleRecord {
 	@Test
-	public void testUnicodeReadName() {
+	void testUnicodeReadName() {
 		byte[] data = HexRead.readFromString(
 				"11 00 09 00 01 38 5E C4 89 5F 00 53 00 68 00 65 00 65 00 74 00 31 00");
 		RecordInputStream in = TestcaseRecordInputStream.create(StyleRecord.sid, data);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java Fri Jan  8 23:50:02 2021
@@ -75,7 +75,7 @@ public final class TestSubRecord {
 	 * read overruns, so the bug was mostly silent.
 	 */
 	@Test
-	public void testReadAll_bug45778() {
+	void testReadAll_bug45778() {
 		RecordInputStream in = TestcaseRecordInputStream.create(dataAutoFilter);
 		ObjRecord or = new ObjRecord(in);
 		byte[] data2 = or.serialize();
@@ -85,7 +85,7 @@ public final class TestSubRecord {
 	}
 
 	@Test
-	public void testReadManualComboWithFormula() {
+	void testReadManualComboWithFormula() {
 		byte[] data = HexRead.readFromString(""
 			+ "5D 00 66 00 "
 			+ "15 00 12 00 14 00 02 00 11 20 00 00 00 00 "
@@ -119,7 +119,7 @@ public final class TestSubRecord {
 	 * ObjRecord back to the proper size.  POI should do the same.
 	 */
 	@Test
-	public void testWayTooMuchPadding_bug46545() {
+	void testWayTooMuchPadding_bug46545() {
 		byte[] data = HexRead.readFromString(""
 			+ "15 00 12 00 14 00 13 00 01 21 00 00 00"
 			+ "00 98 0B 5B 09 00 00 00 00 0C 00 14 00 00 00 00 00 00 00 00"

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java Fri Jan  8 23:50:02 2021
@@ -60,7 +60,7 @@ public final class TestSupBookRecord {
      * tests that we can load the record
      */
     @Test
-    public void testLoadIR() {
+    void testLoadIR() {
         SupBookRecord record = new SupBookRecord(TestcaseRecordInputStream.create(0x01AE, dataIR));
         assertTrue( record.isInternalReferences() );             //expected flag
         assertEquals( 0x4, record.getNumberOfSheets() );    //expected # of sheets
@@ -72,7 +72,7 @@ public final class TestSupBookRecord {
      * tests that we can load the record
      */
     @Test
-    public void testLoadER() {
+    void testLoadER() {
         SupBookRecord record = new SupBookRecord(TestcaseRecordInputStream.create(0x01AE, dataER));
         assertTrue( record.isExternalReferences() );             //expected flag
         assertEquals( 0x2, record.getNumberOfSheets() );    //expected # of sheets
@@ -90,7 +90,7 @@ public final class TestSupBookRecord {
      * tests that we can load the record
      */
     @Test
-    public void testLoadAIF() {
+    void testLoadAIF() {
         SupBookRecord record = new SupBookRecord(TestcaseRecordInputStream.create(0x01AE, dataAIF));
         assertTrue( record.isAddInFunctions() );             //expected flag
         assertEquals( 0x1, record.getNumberOfSheets() );    //expected # of sheets
@@ -102,7 +102,7 @@ public final class TestSupBookRecord {
      */
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testStoreIR() {
+    void testStoreIR() {
         SupBookRecord record = SupBookRecord.createInternalReferences((short)4);
 
         confirmRecordEncoding(0x01AE, dataIR, record.serialize());
@@ -110,7 +110,7 @@ public final class TestSupBookRecord {
 
     @SuppressWarnings("squid:S2699")
     @Test
-    public void testStoreER() {
+    void testStoreER() {
         String url = "testURL";
         String[] sheetNames = { "Sheet1", "Sheet2", };
         SupBookRecord record = SupBookRecord.createExternalReferences(url, sheetNames);
@@ -119,7 +119,7 @@ public final class TestSupBookRecord {
     }
 
     @Test
-    public void testStoreAIF() {
+    void testStoreAIF() {
         SupBookRecord record = SupBookRecord.createAddInFunctions();
         assertEquals(1, record.getNumberOfSheets());
         assertTrue(record.isAddInFunctions());
@@ -127,7 +127,7 @@ public final class TestSupBookRecord {
     }
 
     @Test
-    public void testExternalReferenceUrl() {
+    void testExternalReferenceUrl() {
     	String[] sheetNames = new String[]{"SampleSheet"};
     	final char startMarker = (char)1;
 

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java Fri Jan  8 23:50:02 2021
@@ -45,7 +45,7 @@ public final class TestTableRecord {
 	};
 
 	@Test
-	public void testLoad() {
+	void testLoad() {
 
 		TableRecord record = new TableRecord(TestcaseRecordInputStream.create(0x236, data));
 
@@ -65,7 +65,7 @@ public final class TestTableRecord {
 
 	@SuppressWarnings("squid:S2699")
 	@Test
-    public void testStore()
+    void testStore()
     {
 //    	Offset 0x3bd9 (15321)
 //    	recordid = 0x236, size = 16

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java Fri Jan  8 23:50:02 2021
@@ -53,7 +53,7 @@ public final class TestTextObjectBaseRec
     );
 
     @Test
-    public void testLoad() {
+    void testLoad() {
         RecordInputStream in = TestcaseRecordInputStream.create(data);
         TextObjectRecord record = new TextObjectRecord(in);
 
@@ -66,7 +66,7 @@ public final class TestTextObjectBaseRec
     }
 
     @Test
-    public void testStore() {
+    void testStore() {
         TextObjectRecord record = new TextObjectRecord();
 
         HSSFRichTextString str = new HSSFRichTextString("AB");

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java Fri Jan  8 23:50:02 2021
@@ -50,7 +50,7 @@ public final class TestTextObjectRecord
     );
 
     @Test
-    public void testRead() {
+    void testRead() {
 
         RecordInputStream is =TestcaseRecordInputStream.create(simpleData);
         TextObjectRecord record = new TextObjectRecord(is);
@@ -63,7 +63,7 @@ public final class TestTextObjectRecord
     }
 
     @Test
-    public void testWrite() {
+    void testWrite() {
         HSSFRichTextString str = new HSSFRichTextString("Hello, World!");
 
         TextObjectRecord record = new TextObjectRecord();
@@ -88,7 +88,7 @@ public final class TestTextObjectRecord
      * Zero {@link ContinueRecord}s follow a {@link TextObjectRecord} if the text is empty
      */
     @Test
-    public void testWriteEmpty() {
+    void testWriteEmpty() {
         HSSFRichTextString str = new HSSFRichTextString("");
 
         TextObjectRecord record = new TextObjectRecord();
@@ -111,7 +111,7 @@ public final class TestTextObjectRecord
      * Test that TextObjectRecord serializes logs records properly.
      */
     @Test
-    public void testLongRecords() {
+    void testLongRecords() {
         int[] lengths = {1024, 2048, 4096, 8192, 16384}; //test against strings of different length
         for (int length : lengths) {
             StringBuilder buff = new StringBuilder(length);
@@ -138,7 +138,7 @@ public final class TestTextObjectRecord
      * Test cloning
      */
     @Test
-    public void testClone() {
+    void testClone() {
         String text = "Hello, World";
         HSSFRichTextString str = new HSSFRichTextString(text);
 
@@ -183,7 +183,7 @@ public final class TestTextObjectRecord
         );
 
     @Test
-    public void testLinkFormula() {
+    void testLinkFormula() {
         RecordInputStream is = new RecordInputStream(new ByteArrayInputStream(linkData));
         is.nextRecord();
         TextObjectRecord rec = new TextObjectRecord(is);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java Fri Jan  8 23:50:02 2021
@@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test;
 public final class TestUnicodeNameRecord {
 
 	@Test
-	public void testReadBook() throws IOException {
+	void testReadBook() throws IOException {
 		// This bit used to crash
 		try (HSSFWorkbook book = HSSFTestDataSamples.openSampleWorkbook("unicodeNameRecord.xls")) {
 			HSSFSheet sheet = book.getSheetAt(0);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java Fri Jan  8 23:50:02 2021
@@ -35,7 +35,7 @@ public final class TestWriteAccessRecord
 		+ "20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20";
 
 	@Test
-	public void testMissingStringHeader_bug47001a() {
+	void testMissingStringHeader_bug47001a() {
 		/*
 		 * Data taken from offset 0x0224 in
 		 * attachment 23468 from bugzilla 47001
@@ -66,7 +66,7 @@ public final class TestWriteAccessRecord
 	}
 
 	@Test
-	public void testShortRecordWrittenByMSAccess() {
+	void testShortRecordWrittenByMSAccess() {
 		/*
 		 * Data taken from two example files
 		 * ex42564-21435.xls

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java Fri Jan  8 23:50:02 2021
@@ -50,7 +50,7 @@ import org.junit.jupiter.api.Test;
 @SuppressWarnings("resource")
 public final class TestCFRecordsAggregate {
     @Test
-    public void testCFRecordsAggregate() {
+    void testCFRecordsAggregate() {
         HSSFWorkbook workbook = new HSSFWorkbook();
         HSSFSheet sheet = workbook.createSheet();
 
@@ -121,7 +121,7 @@ public final class TestCFRecordsAggregat
      * Make sure that the CF Header record is properly updated with the number of rules
      */
     @Test
-    public void testNRules() {
+    void testNRules() {
         HSSFWorkbook workbook = new HSSFWorkbook();
         HSSFSheet sheet = workbook.createSheet();
         CellRangeAddress[] cellRanges = {
@@ -142,7 +142,7 @@ public final class TestCFRecordsAggregat
     }
 
     @Test
-    public void testCantMixTypes() {
+    void testCantMixTypes() {
         HSSFWorkbook workbook = new HSSFWorkbook();
         HSSFSheet sheet = workbook.createSheet();
         CellRangeAddress[] cellRanges = {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org