You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/01/31 18:41:16 UTC
Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/
-----------------------------------------------------------
Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
Repository: aurora
Description
-------
The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
Suppress deprecation warnings.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
Diff: https://reviews.apache.org/r/56131/diff/
Testing
-------
Thanks,
David McLaughlin
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Mehrdad Nurolahzade <me...@nurolahzade.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163701
-----------------------------------------------------------
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Jan. 31, 2017, 10:41 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:41 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163719
-----------------------------------------------------------
Master (efffd85) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 31, 2017, 6:41 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 6:41 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163698
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Jan. 31, 2017, 7:41 nachm., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 7:41 nachm.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Joshua Cohen <jc...@apache.org>.
> On Jan. 31, 2017, 7:09 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, line 155
> > <https://reviews.apache.org/r/56131/diff/1/?file=1620441#file1620441line155>
> >
> > Can you link to the commit that did this or something? It would make it much easier to determine later if we can remove it.
+1.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163697
-----------------------------------------------------------
On Jan. 31, 2017, 6:41 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 6:41 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163697
-----------------------------------------------------------
Ship it!
Ship It!
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java (line 155)
<https://reviews.apache.org/r/56131/#comment235171>
Can you link to the commit that did this or something? It would make it much easier to determine later if we can remove it.
- Zameer Manji
On Jan. 31, 2017, 10:41 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:41 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163733
-----------------------------------------------------------
Master (efffd85) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 31, 2017, 10:50 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:50 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 10:50 p.m.)
Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
Repository: aurora
Description
-------
The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
Suppress deprecation warnings.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
Diff: https://reviews.apache.org/r/56131/diff/
Testing
-------
Thanks,
David McLaughlin
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163692
-----------------------------------------------------------
Master (efffd85) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/offers/RandomJitterReturnDelay
Test coverage missing for org/apache/aurora/scheduler/mesos/MesosTaskFactory$MesosTaskFactoryImpl
Test coverage missing for org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$1
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$2
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor$1
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftWorkload$ThriftWorkloadCounterImpl
Test coverage missing for org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl
Test coverage missing for org/apache/aurora/scheduler/thrift/Thresholds
Test coverage missing for org/apache/aurora/scheduler/thrift/SchedulerThriftInterface
Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl
Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl$2
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl$1
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
Test coverage missing for org/apache/aurora/scheduler/events/NotifyingSchedulingFilter
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEventModule$1
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$HostAttributesChanged
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 11.304 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 31, 2017, 6:41 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 6:41 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163693
-----------------------------------------------------------
@ReviewBot retry
- David McLaughlin
On Jan. 31, 2017, 6:41 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 6:41 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163717
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Jan. 31, 2017, 7:41 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 7:41 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163696
-----------------------------------------------------------
Master (efffd85) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ModuleParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroIniParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
Test coverage missing for org/apache/aurora/scheduler/storage/db/PruneVictim
Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$OutputConfig
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$ContentFactoryPair
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$InputConfig
Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl
Test coverage missing for org/apache/aurora/scheduler/scheduling/RescheduleCalculator$RescheduleCalculatorImpl$1
Test coverage missing for org/apache/aurora/scheduler/offers/RandomJitterReturnDelay
Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl$2
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl$1
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 56.049 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 31, 2017, 6:41 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 6:41 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 56131: Suppress role deprecation warning as
replacement is not yet ready.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163714
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Jan. 31, 2017, 10:41 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:41 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
>
> Suppress deprecation warnings.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137
>
> Diff: https://reviews.apache.org/r/56131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>