You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by hush-hush <gi...@git.apache.org> on 2016/06/16 13:38:54 UTC
[GitHub] thrift pull request #1029: Use 'pre' HTML tag when generating non escaped do...
GitHub user hush-hush opened a pull request:
https://github.com/apache/thrift/pull/1029
Use 'pre' HTML tag when generating non escaped documentation.
This allow clearer documentation and avoid adding HTML tag in the .thrift comments to generate readable HTML
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hush-hush/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1029.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1029
----
commit c41a292c68c1fd43019f0af6faa94cc57fe57050
Author: Maxime Mouial <ma...@scmfrance.fr>
Date: 2016-05-11T15:07:53Z
Use 'pre' HTML tag when generating non escaped documentation.
This allow clearer documentation and avoid adding HTML tag in the .thrift comments to generate readable HTML
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1029: THRIFT-3823: Use 'pre' HTML tag when generating non esca...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1029
I added the failure to THRIFT-3826 which documents our issues on the windows side pulling libraries from third party sites. I'll see if I can submit a fix to work around this one, so hold on..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1029: THRIFT-3823: Use 'pre' HTML tag when generating non esca...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1029
@jfarrell or @hush-hush could you please close this? There were two pull requests for this Jira ticket and I only put one of them into the "This closes" part of the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1029: THRIFT-3823: Use 'pre' HTML tag when generating n...
Posted by hush-hush <gi...@git.apache.org>.
Github user hush-hush closed the pull request at:
https://github.com/apache/thrift/pull/1029
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1029: THRIFT-3823: Use 'pre' HTML tag when generating non esca...
Posted by hush-hush <gi...@git.apache.org>.
Github user hush-hush commented on the issue:
https://github.com/apache/thrift/pull/1029
OK, closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1029: THRIFT-3823: Use 'pre' HTML tag when generating non esca...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1029
I tested the download of openssl which was failing last night, it looks like the external site is up again and responsive, so if you rebase and push it'll kick another build that should succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1029: Use 'pre' HTML tag when generating non escaped documenta...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1029
This is for THRIFT-3823, you might want to change the pull request title.
As for the Appveyor build failure, that's documented in THRIFT-3826 (related; I just added a comment).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---