Re: [PR] TIKA-4980: Extract previews from Olympus ORF, Panasonic RW2, Epson ERF, Kodak KDC and Leaf MOS [tika]

["tballison (via GitHub)" <gi...@apache.org>]

tballison commented on PR #3370:
URL: https://github.com/apache/tika/pull/3370#issuecomment-6288919913

   My :robot: 's review. Let me know what you think.
   
   ```
   1. OM System ORFs get no preview. OM Digital Solutions bodies (OM-1, OM-3, OM-5) write an OM SYSTEM\0 MakerNote header: 16 bytes, byte-order marker at offset 12, offsets relative to the MakerNote start (ExifTool MakerNoteOlympus3, added in 12.41). raw.pixls.us/data/OM Digital Solutions/OM-3/P5048182.ORF returns no embedded documents with this PR, where ExifTool finds a 920 KB preview. Please handle that header and add a small test file for it.
     2. Stale claim in the testERF javadoc. It says ERF is detected by its compression code (32769), but the detector uses the Make plus the raw-sensor markers, as RawTiffDetector's javadoc says.
     3. CHANGES entry: please cut it to 2–3 lines. Add a separate line for the CopyUnknownFieldsHandler change: it applies to every image format metadata-extractor reads, not just raws, so a tag whose description throws is now skipped instead of failing the parse.
   
     Optional: narrow that catch (RuntimeException) to the exceptions descriptors actually throw (ClassCastException, index errors), so a real bug isn't swallowed silently.
   ```
   
   On catching RuntimeException, if you can catch and rethrow a SecurityException so that percolates up, that'd be great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org