You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2019/07/20 23:45:22 UTC
[pool] OK to commit?
I am working on a patch for POOL-361. I think the analysis in the
ticket is correct and I think I know how to fix it (move validation into
create()). I think I still have commit karma, but have not committed to
commons in quite a while. Any objections to me committing directly to
[pool]?
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] OK to commit?
Posted by James Carman <ja...@carmanconsulting.com>.
If you feel nervous, you can always push a branch or something and let
folks take a look.
On Sat, Jul 20, 2019 at 8:06 PM Matt Sicker <bo...@gmail.com> wrote:
> I believe it’s CTR on Pool, so go for it.
>
> On Sat, Jul 20, 2019 at 18:45, Phil Steitz <ph...@gmail.com> wrote:
>
> > I am working on a patch for POOL-361. I think the analysis in the
> > ticket is correct and I think I know how to fix it (move validation into
> > create()). I think I still have commit karma, but have not committed to
> > commons in quite a while. Any objections to me committing directly to
> > [pool]?
> >
> > Phil
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> > --
> Matt Sicker <bo...@gmail.com>
>
Re: [pool] OK to commit?
Posted by Matt Sicker <bo...@gmail.com>.
I believe it’s CTR on Pool, so go for it.
On Sat, Jul 20, 2019 at 18:45, Phil Steitz <ph...@gmail.com> wrote:
> I am working on a patch for POOL-361. I think the analysis in the
> ticket is correct and I think I know how to fix it (move validation into
> create()). I think I still have commit karma, but have not committed to
> commons in quite a while. Any objections to me committing directly to
> [pool]?
>
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
> --
Matt Sicker <bo...@gmail.com>
Re: [pool] OK to commit?
Posted by Phil Steitz <ph...@gmail.com>.
On 7/20/19 7:23 PM, Gary Gregory wrote:
> Go for it. As Matt pointed out, you can always create a PR and see have
> Travis validate builds.
OK, I did the PR. It has been a while since I have committed to [pool],
so some careful review would be most appreciated. The intent should be
clear from the diffs - I just moved the validation into create() when
testOnCreate is enabled and tried to make sure that counters are
maintained. I am not in love with the multiple returns in that method,
which I made slightly worse; but I could not see a simpler fix.
Phil
>
> Gary
>
> On Sat, Jul 20, 2019 at 7:45 PM Phil Steitz <ph...@gmail.com> wrote:
>
>> I am working on a patch for POOL-361. I think the analysis in the
>> ticket is correct and I think I know how to fix it (move validation into
>> create()). I think I still have commit karma, but have not committed to
>> commons in quite a while. Any objections to me committing directly to
>> [pool]?
>>
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] OK to commit?
Posted by Gary Gregory <ga...@gmail.com>.
Go for it. As Matt pointed out, you can always create a PR and see have
Travis validate builds.
Gary
On Sat, Jul 20, 2019 at 7:45 PM Phil Steitz <ph...@gmail.com> wrote:
> I am working on a patch for POOL-361. I think the analysis in the
> ticket is correct and I think I know how to fix it (move validation into
> create()). I think I still have commit karma, but have not committed to
> commons in quite a while. Any objections to me committing directly to
> [pool]?
>
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>