You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2022/08/01 16:55:52 UTC

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18804


Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................

IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

This patch upgrade the JAVA thrift components to thrift-0.16.0. Most of
refactoring revolves around moving TSerializer and TDeserializer
intantiation within try block to after the following Apache Thrift
commit from thrift-0.14.0:

63213c1 Implements TConfiguration for java

Testing:
- Pass core tests.

Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
---
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
8 files changed, 48 insertions(+), 38 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/18804/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18804

to look at the new patch set (#2).

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................

IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

This patch upgrade the JAVA thrift components to thrift-0.16.0. Most of
refactoring revolves around moving TSerializer and TDeserializer
intantiation within try block to after the following Apache Thrift
commit from thrift-0.14.0:

63213c1 Implements TConfiguration for java

Testing:
- Pass core tests.

Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
---
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
8 files changed, 48 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/18804/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 22:32:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 21:21:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 16:25:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8410/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 03:08:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................

IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

This patch upgrade the JAVA thrift components to thrift-0.16.0. Most of
refactoring revolves around moving TSerializer and TDeserializer
intantiation within try block to after the following Apache Thrift
commit from thrift-0.14.0:

63213c1 Implements TConfiguration for java

Testing:
- Pass core tests.

Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Reviewed-on: http://gerrit.cloudera.org:8080/18804
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java
M fe/src/main/java/org/apache/impala/common/JniUtil.java
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
8 files changed, 48 insertions(+), 38 deletions(-)

Approvals:
  Riza Suminto: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8409/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Aug 2022 20:35:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11069/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Aug 2022 17:16:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8408/


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Aug 2022 13:59:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11109/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 02:56:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 2:

> Patch Set 2: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8410/

Hit by IMPALA-11160 and flakiness in test_event_based_replication.


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 08:26:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 01:27:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8408/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Aug 2022 09:05:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8418/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 00:41:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 05:33:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8410/


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 08:01:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 )

Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0
......................................................................


Patch Set 2: Code-Review+2

Rebase and carry +2 due to merge conflict in JniCatalog.java.


-- 
To view, visit http://gerrit.cloudera.org:8080/18804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a146d3a36938d43225da7c12bfe676c445d3944
Gerrit-Change-Number: 18804
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 03:06:42 +0000
Gerrit-HasComments: No