You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/04 04:54:13 UTC

[PR] Clarify HighFrequencyInvocation coding rules [shardingsphere]

terrymanu opened a new pull request, #39722:
URL: https://github.com/apache/shardingsphere/pull/39722

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clarify HighFrequencyInvocation coding rules [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39722:
URL: https://github.com/apache/shardingsphere/pull/39722#issuecomment-5535947855

   ### Result
   
   **Review Result: Mergeable**
   
   The rules fully cover the user-specified purpose, high-frequency definition, annotation scope, caching semantics, performance constraints, and three prohibitions. No blocking issues were found.
   
   ### Evidence
   
   - The rules in `CODE_OF_CONDUCT.md:67` and `docs/community/content/involved/conduct/code.en.md:71` are identical after indentation normalization.
   - `docs/community/content/involved/conduct/code.cn.md:71` is semantically consistent with the English rules item by item.
   - The changes are limited to the existing `@HighFrequencyInvocation` sections in the three files.
   - Deterministic validation, source-read traces, the full semantic test suite, and diff checks all passed.
   
   ### Coverage
   
   - Candidate type: Standalone local candidate.
   - Baseline: The working tree at the start of the task; pre-existing untracked `__pycache__` directories were excluded and preserved.
   - Reviewed files: `CODE_OF_CONDUCT.md`, `docs/community/content/involved/conduct/code.en.md`, and `docs/community/content/involved/conduct/code.cn.md`.
   - Behavior cluster: The `@HighFrequencyInvocation` coding rules and English-Chinese synchronization.
   - Root-cause and requirements analysis, impact assessment, verification, and final convergence review were completed; no unresolved evidence gaps remain.
   - This result covers code-scope correctness only; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clarify HighFrequencyInvocation coding rules [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39722:
URL: https://github.com/apache/shardingsphere/pull/39722


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org