You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2022/05/16 20:39:18 UTC

[jena] branch main updated: JENA-2322: Remove over-long DNS punycode test

This is an automated email from the ASF dual-hosted git repository.

andy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/jena.git


The following commit(s) were added to refs/heads/main by this push:
     new e291acb171 JENA-2322: Remove over-long DNS punycode test
     new d363c442d9 Merge pull request #1313 from afs/iri-j19
e291acb171 is described below

commit e291acb1711fb9f0cc6e43bdf4c589b8666b3fe2
Author: Andy Seaborne <an...@apache.org>
AuthorDate: Mon May 16 15:44:53 2022 +0100

    JENA-2322: Remove over-long DNS punycode test
---
 .../src/main/java/org/apache/jena/iri/ViolationCodes.java   |  4 ----
 .../src/main/xml/org/apache/jena/iri/impl/violations.xml    | 13 +++++++++++--
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/jena-iri/src/main/java/org/apache/jena/iri/ViolationCodes.java b/jena-iri/src/main/java/org/apache/jena/iri/ViolationCodes.java
index 0801d009ff..eee04add3e 100644
--- a/jena-iri/src/main/java/org/apache/jena/iri/ViolationCodes.java
+++ b/jena-iri/src/main/java/org/apache/jena/iri/ViolationCodes.java
@@ -4491,8 +4491,6 @@ This class is not part of the API.
 
       "http://xn--andr--ep-.example.org/",
 
-      "http://xn.example.\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u333 [...]
-
                 },
 
                 new String[]{
@@ -6941,8 +6939,6 @@ URI producers should provide these registered names in the IDNA encoding, rather
 
      <li>&lt;<code>http://xn--andr--ep-.example.org/</code>&gt;</li>
 
-     <li>&lt;<code>http://xn.example.\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u3333\u333 [...]
-
         </ul>
 
 */
diff --git a/jena-iri/src/main/xml/org/apache/jena/iri/impl/violations.xml b/jena-iri/src/main/xml/org/apache/jena/iri/impl/violations.xml
index d05a897c2f..c1734445c4 100644
--- a/jena-iri/src/main/xml/org/apache/jena/iri/impl/violations.xml
+++ b/jena-iri/src/main/xml/org/apache/jena/iri/impl/violations.xml
@@ -1243,8 +1243,17 @@ URI producers should provide these registered names in the IDNA encoding, rather
 	    <!-- REMOVE !! bits to uncomment
 	    <bad>http://xn-!!-andr-!!-ep.example.org/</bad>
 	    <bad>http://xn-!!-a-bpad.example.org/</bad>-->
-      <!-- Truncated in the java to 2000 bytes -->
-	    <bad>http://xn.example.<unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><unicode>3333</unicode><uni [...]
+      <!-- Was: (DNS name too long. 256 ASCII chars per component is the limit.
+      <bad>http://xn.example.<unicode>3333</unicode><unicode>3333</unicode>
+      ....
+      <unicode>3333</unicode><unicode>3333</unicode>/</bad>
+      for 1484 occurrences, over 5K bytes. 
+
+      In Java19, the error changes to "input too long" but no indication as to where it is
+      from. This is assumed to be a JDK change; no jena-iri code changed when it started
+      raising an exception.
+      -->
+
     </violation>
     <!--
     <violation>