You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/16 08:52:00 UTC

[GitHub] [tvm] junrushao1994 commented on pull request #10066: [TIR] Add software pipelining

junrushao1994 commented on pull request #10066:
URL: https://github.com/apache/tvm/pull/10066#issuecomment-1041254307


   Hey thanks @vinx13 for the huge effort! The PR overall is in pretty good shape, but there are only one thing we need to further improve: I noticed that there are a few interesting special handlings for:
   
   - GetWmmaFragmentSize
   - RewriteWmmaFragmentIndex
   - tvm_load_matrix_sync
   - tvm_store_matrix_sync
   - tvm_mma_sync
   - tvm_access_ptr
   
   A good news to me is that all of the above are fundamentally used in only one method `RewriteOpaqueAccesses`. To make sure future developers are able to easier extend the system, we would probably want to make sure that the pass itself is intrinsic agnostic, and the special handling logic is split into a separate method out of the class.
   
   Let me know if it could work! Thanks a lot!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org