[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10328: IGNITE-17383 Stop IdleVerify process for an inactive cluster with per…

[GitBox <gi...@apache.org>]

J-Bakuli commented on code in PR #10328:
URL: https://github.com/apache/ignite/pull/10328#discussion_r1037095294


##########
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/cache/IdleVerify.java:
##########
@@ -346,6 +347,9 @@ private void cacheIdleVerifyV2(
                 IDLE_VERIFY_FILE_PREFIX + LocalDateTime.now().format(TIME_FORMATTER) + ".txt");
 
             try (PrintWriter pw = new PrintWriter(f)) {
+                if (client.state().state() == ClusterState.INACTIVE)

Review Comment:
   It was decided to print the info re this into idle_verify-[date].txt which is specific for idle_verify, into control utility cmd output and not into control-utility.log itself.
   
   Thus as per the current changes in this PR if cluster is inactive and has persistent data regions:
   - exception "Exception: org.apache.ignite.IgniteException
   Can not perform the operation because the cluster is inactive. Note, that the cluster is considered inactive by default if Ignite Persistent Store is used to let all the nodes join the cluster. To activate the cluster call Ignite.active(true)." is printed into idle_verify-[date].txt;
   - "idle_verify does not work on an inactive cluster with persistence" is printed into control utility output not log itself.
   
   Printing exceptions in IdleVerifyResultV2.print() is now limited to several ones with no IgniteException among them. It was decided to avoid creating smth like IgniteInactiveClusterWithPersistenceException.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org