You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/07/19 08:15:44 UTC
[GitHub] [ignite] SammyVimes commented on a diff in pull request #10161: IGNITE-17386 Add info about Java 17 support to docs
SammyVimes commented on code in PR #10161:
URL: https://github.com/apache/ignite/pull/10161#discussion_r924197835
##########
docs/_docs/includes/java9.adoc:
##########
@@ -34,5 +38,26 @@ application:
--illegal-access=permit
----
-
-
+tab:Java 17[]
+[source,shell]
+----
+--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED \
+--add-exports=java.base/sun.nio.ch=ALL-UNNAMED \
+--add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED \
+--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
+--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED \
Review Comment:
You don't actually need --add-exports, they're compile time flags
##########
docs/_docs/includes/java9.adoc:
##########
@@ -34,5 +38,26 @@ application:
--illegal-access=permit
----
-
-
+tab:Java 17[]
+[source,shell]
+----
+--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED \
+--add-exports=java.base/sun.nio.ch=ALL-UNNAMED \
+--add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED \
+--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
+--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED \
+--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED \
+--add-opens=java.base/jdk.internal.misc=ALL-UNNAMED \
+--add-opens=java.base/sun.nio.ch=ALL-UNNAMED \
+--add-opens=java.base/sun.nio.ch=ALL-UNNAMED \
+--add-opens=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED \
+--add-opens=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
+--add-opens=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED \
+--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED \
+--add-opens=java.base/java.io=ALL-UNNAMED \
+--add-opens=java.base/java.nio=ALL-UNNAMED \
+--add-opens=java.base/java.util=ALL-UNNAMED \
+--add-opens=java.base/java.lang=ALL-UNNAMED \
+--illegal-access=permit
Review Comment:
I believe --illegal-access=permit is not available for java17 anymore, that's why we have so many add-opens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org