[GitHub] [skywalking] pg-yang commented on a diff in pull request #10343: Polish aws-firehose-receiver to adapt existing OTEL proto

["pg-yang (via GitHub)" <gi...@apache.org>]

pg-yang commented on code in PR #10343:
URL: https://github.com/apache/skywalking/pull/10343#discussion_r1096618544


##########
oap-server/server-receiver-plugin/aws-firehose-receiver/README.MD:
##########
@@ -0,0 +1,7 @@
+### Notice
+The OTEL proto in this module copy from [opentelemetry-proto v0.7.0](https://github.com/open-telemetry/opentelemetry-proto/tree/v0.7.0) as AWS firehose only support OTEL 0.7, and rewrite follows :

Review Comment:
   OTEL 0.7 has little difference from existing OTEL proto, for example:
   ```
   instrumentationLibraryMetrics (0.7)-> scopeMetrics
   doubleSummary, intSummary  (0.7) -> summary
   labels (0.7) -> attributes
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org