You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "korowa (via GitHub)" <gi...@apache.org> on 2023/03/30 16:51:41 UTC

[GitHub] [arrow-datafusion] korowa opened a new pull request, #5796: fix: `case` expressions type coercion

korowa opened a new pull request, #5796:
URL: https://github.com/apache/arrow-datafusion/pull/5796

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #5694.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   While building projection schema (initial planning step), `CASE` return type calculated as output type of first `WHEN ... THEN ...` which could potentially cause erroneous type coercions at later planning stages.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Output type of `CASE` expressions, while building projection schema, now considers all THEN-types and ELSE-type (if exists) and uses common `get_coerce_type_for_case_when` type coercion routine.
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   Test cases for `CASE` expression with mixed NULL/NOT NULL THEN/ELSE-types added 
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] korowa commented on pull request #5796: fix: `case` expressions type coercion

Posted by "korowa (via GitHub)" <gi...@apache.org>.
korowa commented on PR #5796:
URL: https://github.com/apache/arrow-datafusion/pull/5796#issuecomment-1491367476

   My bad, this is a complete duplicate -- should have checked before creating PR.
   
   Good news still, that #5694 can be closed after #5734 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #5796: fix: `case` expressions type coercion

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5796:
URL: https://github.com/apache/arrow-datafusion/pull/5796#issuecomment-1490753382

   Is this related to https://github.com/apache/arrow-datafusion/pull/5734 from @mslapek ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] korowa closed pull request #5796: fix: `case` expressions type coercion

Posted by "korowa (via GitHub)" <gi...@apache.org>.
korowa closed pull request #5796: fix: `case` expressions type coercion
URL: https://github.com/apache/arrow-datafusion/pull/5796


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org