You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/09/26 18:23:38 UTC
[jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron domain
classes (#148)
@zack-shoylev Let me know your preference on the deprecations. Thx!
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack fix/boolean-methods
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/148
-- Commit Summary --
* Prefer Boolean over primitive boolean in OpenStack Neutron domain classes
-- File Changes --
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/ExternalGatewayInfo.java (9)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/Network.java (44)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/Port.java (69)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/Router.java (23)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2/extensions/RouterApiMockTest.java (10)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2/features/PortApiMockTest.java (12)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/148.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/148.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Jeremy Daggett <no...@github.com>.
I thought I had those changes in the previous commit. ?? Anyway... I removed the remaining unnecessary `@Deprecation` annotations.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57234856
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Andrew Phillips <no...@github.com>.
> */
> + @Deprecated
Will a user even notice this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148/files#r18181929
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Frédéric Brouillé <no...@github.com>.
Changes look good. And deprecations are not necessary.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57475659
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Zack Shoylev <no...@github.com>.
Also backport
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57493564
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Zack Shoylev <no...@github.com>.
Looks good, let's merge it!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57493546
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Andrew Phillips <no...@github.com>.
Changes look good to me - about the deprecation part: will users notice this in their code?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57226670
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1759](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1759/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57190535
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #439](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/439/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57236110
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Jeremy Daggett <no...@github.com>.
Merging shortly...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57493886
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #437](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/437/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-56986497
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #438](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/438/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57190765
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Jeremy Daggett <no...@github.com>.
Pushed to master 7557224 and 1.8.x 16e87b7
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57497942
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1756](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1756/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-56986158
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1760](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1760/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57235955
Re: [jclouds-labs-openstack] Prefer Boolean in OpenStack Neutron
domain classes (#148)
Posted by Zack Shoylev <no...@github.com>.
Do not deprecate. Just change the code. Apply breaking changes and reduce code while we can (Beta)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/148#issuecomment-57026077