You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by andschwa <gi...@git.apache.org> on 2018/04/24 00:06:05 UTC

[GitHub] zookeeper pull request #505: ZOOKEEPER-3025: Make `hashtable` search `includ...

GitHub user andschwa opened a pull request:

    https://github.com/apache/zookeeper/pull/505

    ZOOKEEPER-3025: Make `hashtable` search `include`

    When ZOOKEEPER-2999 removed the directory side-effect of
    `include_directories(include)`, and added it as a target-level include
    to the `zookeeper` library, this broke the Windows build. It worked on
    Linux (where the patch was tested) because `winconfig.h` and is not
    included, but on Windows, the `hashtable` library included
    `winconfig.h` (found in `include`) but no longer knew where to find
    it. The fix is to add `include` to the `hashtable` library's list of
    include directories.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-3025

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #505
    
----
commit 69afce4df5a5cc71999d67c87578e236b58d17a1
Author: Andrew Schwartzmeyer <an...@...>
Date:   2018-04-23T23:38:03Z

    ZOOKEEPER-3025: Make `hashtable` search `include`
    
    When ZOOKEEPER-2999 removed the directory side-effect of
    `include_directories(include)`, and added it as a target-level include
    to the `zookeeper` library, this broke the Windows build. It worked on
    Linux (where the patch was tested) because `winconfig.h` and is not
    included, but on Windows, the `hashtable` library included
    `winconfig.h` (found in `include`) but no longer knew where to find
    it. The fix is to add `include` to the `hashtable` library's list of
    include directories.

----


---

[GitHub] zookeeper pull request #505: ZOOKEEPER-3025: Make `hashtable` search `includ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/505


---

[GitHub] zookeeper issue #505: ZOOKEEPER-3025: Make `hashtable` search `include`

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/505
  
    +1. Thanks @andschwa 


---

[GitHub] zookeeper issue #505: ZOOKEEPER-3025: Make `hashtable` search `include`

Posted by andschwa <gi...@git.apache.org>.

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/505
  
    Built successfully both in-tree and out-of-tree on Windows using the VS generator, also successfully built with the Ninja generator 😉 


---