You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/04/16 08:13:52 UTC

[GitHub] [flink] reswqa commented on a diff in pull request #22403: [BP-1.16][FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag

reswqa commented on code in PR #22403:
URL: https://github.com/apache/flink/pull/22403#discussion_r1167767444


##########
docs/setup_docs.sh:
##########
@@ -41,10 +41,10 @@ cd tmp
 
 # Since there's no documentation yet available for a release branch,
 # we only get the documentation from the main branch
-integrate_connector_docs elasticsearch v3.0.0-docs
-integrate_connector_docs aws v4.1.0-docs
-integrate_connector_docs opensearch v1.0.0
-integrate_connector_docs mongodb v1.0.0-docs
+integrate_connector_docs elasticsearch v3.0

Review Comment:
   Thanks @healchow for the review.
    
   > I see that you have created a similar PR: https://github.com/apache/flink/pull/22402 
   Why not fix this in one PR?
   
   In fact, these two PRs were created to pick the changes in A into the release-1.17 and release-1.16 branches([BP-xx] can also be seen from the title). Otherwise, how to merge code into two different branches in one PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org