You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/13 15:03:00 UTC
[jira] [Commented] (METRON-1868) metron-committer-common
incorrectly checking CHOSEN_REPO
[ https://issues.apache.org/jira/browse/METRON-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685337#comment-16685337 ]
ASF GitHub Bot commented on METRON-1868:
----------------------------------------
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1260
METRON-1868: metron-committer-common incorrectly checking CHOSEN_REPO
## Contributor Comments
I found a minor bug when trying to use `prepare-commit` against the metron-bro-plugin-kafka repo. This should fix that.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/metron METRON-1868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1260
----
commit f5a659707fe978af9ef365897db3fbcbe3b63f96
Author: Jon Zeolla <ze...@...>
Date: 2018-11-13T15:00:38Z
METRON-1868: metron-committer-common incorrectly checking CHOSEN_REPO
----
> metron-committer-common incorrectly checking CHOSEN_REPO
> --------------------------------------------------------
>
> Key: METRON-1868
> URL: https://issues.apache.org/jira/browse/METRON-1868
> Project: Metron
> Issue Type: Task
> Reporter: Jon Zeolla
> Assignee: Jon Zeolla
> Priority: Minor
>
> It appears that metron repo is hard coded, but needs to be more flexible based on the project having multiple repos.
> It appears that the namespace for CHOSEN_REPO may not be appropriate.
> https://github.com/apache/metron/blob/master/dev-utilities/committer-utils/metron-committer-common#L115
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)