[GitHub] [helix] qqu0127 commented on a diff in pull request #2176: Wire in the logic for TaskExecutor reset timeout parameter

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2176:
URL: https://github.com/apache/helix/pull/2176#discussion_r921429383


##########
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java:
##########
@@ -72,8 +78,8 @@ public DefaultMessagingService(HelixManager manager) {
         new ParticipantStatusMonitor(isParticipant, manager.getInstanceName()),
         new MessageQueueMonitor(manager.getClusterName(), manager.getInstanceName()));
     _asyncCallbackService = new AsyncCallbackService();
-    _taskExecutor.registerMessageHandlerFactory(MessageType.TASK_REPLY.name(),
-        _asyncCallbackService);
+    _taskExecutor.registerMessageHandlerFactory(_asyncCallbackService, TaskExecutor.DEFAULT_PARALLEL_TASKS, resetTimeoutMs);

Review Comment:
   This is essentially the same with method that takes in `resetTimeoutMs`. 
   `_asyncCallbackService` is an instance of `MultiTypeMessageHandlerFactory` so we can use method `  public void registerMessageHandlerFactory(MultiTypeMessageHandlerFactory factory,
         int threadPoolSize, int resetTimeoutMs) `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org