You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2016/09/24 21:37:50 UTC
[GitHub] incubator-metron pull request #272: METRON-453: Add a stellar shell function...
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/272
METRON-453: Add a stellar shell function to open an external editor and return the editor's contents
In order to create multiline strings (e.g. JSON or grok statements), we should have a stellar shell function which can open up an editor (specified by the `EDITOR` or `VISUAL` environment variable) optionally initialized by the contents of a variable and return the output of the editor when saved and closed.
This work builds on METRON-452 (#269), so it will be hard to review until that is merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron stellar_edit_func
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #272
----
commit 631b1a4adf416da8d9afc01f5798b67cf4c71934
Author: cstella <ce...@gmail.com>
Date: 2016-09-24T05:15:12Z
METRON-452: Add rudimentary configuration management functions to Stellar
commit b377355f7a06fec890f45307d76c136300d82a0b
Author: cstella <ce...@gmail.com>
Date: 2016-09-24T14:26:02Z
Timing issue.
commit a1faf2b9f452218112b66d88c073c550a1879d8c
Author: cstella <ce...@gmail.com>
Date: 2016-09-24T15:37:27Z
adding edit function.
commit 00a46745f316c21f8ea2c24caeda4d2c2239da97
Author: cstella <ce...@gmail.com>
Date: 2016-09-24T15:40:36Z
test typo.
commit 3d406b42a4f34e1acfef0b3b883f799ddae70007
Author: cstella <ce...@gmail.com>
Date: 2016-09-24T21:35:16Z
METRON-453: Add a stellar shell function to open an external editor and return the editor's contents
commit 68b6fae92bac2395d24f97bbc37a0e3be74368ea
Author: cstella <ce...@gmail.com>
Date: 2016-09-24T21:35:41Z
Merge branch 'METRON-452' into stellar_edit_func
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #272: METRON-453: Add a stellar shell function...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #272: METRON-453: Add a stellar shell function to ope...
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/272
+1 tested on quickdev and was able to use SHELL_EDIT with and without the optional param and with various input and on both vi and nano as editors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---