You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/13 16:26:50 UTC

[GitHub] [tvm] areusch commented on a diff in pull request #11304: Fix Hexagon build using ci.py

areusch commented on code in PR #11304:
URL: https://github.com/apache/tvm/pull/11304#discussion_r872580188


##########
tests/scripts/ci.py:
##########
@@ -195,6 +195,8 @@ def docker(name: str, image: str, scripts: List[str], env: Dict[str, str], inter
         command.append("-t")
         scripts = ["interact() {", "  bash", "}", "trap interact 0", ""] + scripts
 
+    command.append("--net=host")

Review Comment:
   could we make this one an option rather than on by default? it has security implications when enabled (e.g. it grants the container processes access to all the host's network interfaces)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org