You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/23 09:21:22 UTC
Review Request 35772: Made post-reviews.py print parent diff only if
one exists.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35772/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository: mesos
Description
-------
Made the `... with parent diff created from:` show up only if such parent diff exists.
Before:
```
Creating diff of:
4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py print parent diff only if one exists.
... with parent diff created from:
```
After:
```
Creating diff of:
4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py print parent diff only if one exists.
```
Diffs
-----
support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
Diff: https://reviews.apache.org/r/35772/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 35772: Made post-reviews.py print parent diff only
if one exists.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35772/#review88935
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On June 23, 2015, 7:21 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35772/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 7:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the `... with parent diff created from:` show up only if such parent diff exists.
>
> Before:
> ```
> Creating diff of:
> 4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py print parent diff only if one exists.
>
> ... with parent diff created from:
> ```
>
> After:
> ```
> Creating diff of:
> 4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py print parent diff only if one exists.
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35772: Made post-reviews.py print parent diff only
if one exists.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35772/#review88952
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35772]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 7:21 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35772/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 7:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the `... with parent diff created from:` show up only if such parent diff exists.
>
> Before:
> ```
> Creating diff of:
> 4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py print parent diff only if one exists.
>
> ... with parent diff created from:
> ```
>
> After:
> ```
> Creating diff of:
> 4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py print parent diff only if one exists.
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>