You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mkzung (via GitHub)" <gi...@apache.org> on 2026/08/02 12:24:44 UTC

Re: [PR] GH-50695: [C++] Use the full unsigned range for unsigned dictionary index types [arrow]

mkzung commented on code in PR #50696:
URL: https://github.com/apache/arrow/pull/50696#discussion_r3698994492


##########
cpp/src/arrow/array/builder_adaptive.cc:
##########


Review Comment:
   Still needed for the value type: AdaptiveUIntBuilder::Append takes uint64_t, AdaptiveIntBuilder::Append takes int64_t, so anything above int64 max has no way in through the int builder. use_unsigned_range widens the index type it emits, not what a caller can hand it. Both are public API too. Happy to open a follow-up if you want them folded together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org