You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seatunnel.apache.org by Wenjun Ruan <be...@gmail.com> on 2022/03/04 10:27:14 UTC
Re: [PROPOAL] Strict PR title when merging it
BTW, when committers merge PR also needs to pay attention to
simplifying the commit message.
I find there exist many duplicate commit messages in the git log.
The commit message can be edited when merging PR, and remove the
duplicate message.
On Wed, Feb 16, 2022 at 12:01 PM Jiajie Zhong <zh...@gmail.com> wrote:
>
> I think is not related to the first PR title but the first line of commit message in the first commit
>
> Maybe using some bot or tool like git hook would help a little, but the better way to solve
> this is we should pay more attention when we merge PR.
>
> Bot only makes sure we have a title. but I think only we could determine whether the title
> is accurate or not.
>
> But I also like to see if we could find some bot or tool like git hook to do the first step
> before we.
>
> Cheers,
> — Jiajie Zhong
>
>
Re: [PROPOAL] Strict PR title when merging it
Posted by Jiajie Zhong <zh...@gmail.com>.
Yeah
I agree with Wenun, we committers should also pay attention when we merging
PR. Changing git log makes out log short and meaningful, and also look good
when checking log
On Fri, Mar 4, 2022 at 6:27 PM Wenjun Ruan <be...@gmail.com> wrote:
>
> BTW, when committers merge PR also needs to pay attention to
> simplifying the commit message.
>
> I find there exist many duplicate commit messages in the git log.
>
> The commit message can be edited when merging PR, and remove the
> duplicate message.
>
>
> On Wed, Feb 16, 2022 at 12:01 PM Jiajie Zhong <zh...@gmail.com> wrote:
> >
> > I think is not related to the first PR title but the first line of commit message in the first commit
> >
> > Maybe using some bot or tool like git hook would help a little, but the better way to solve
> > this is we should pay more attention when we merge PR.
> >
> > Bot only makes sure we have a title. but I think only we could determine whether the title
> > is accurate or not.
> >
> > But I also like to see if we could find some bot or tool like git hook to do the first step
> > before we.
> >
> > Cheers,
> > — Jiajie Zhong
> >
> >
--
Best Wish
— Jiajie