You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/17 14:50:46 UTC

[GitHub] [spark] viirya commented on a change in pull request #24894: [SPARK-28058][DOC] Add a note to DROPMALFORMED mode of CSV for column pruning

viirya commented on a change in pull request #24894: [SPARK-28058][DOC] Add a note to DROPMALFORMED mode of CSV for column pruning
URL: https://github.com/apache/spark/pull/24894#discussion_r294337292
 
 

 ##########
 File path: python/pyspark/sql/readwriter.py
 ##########
 @@ -441,7 +441,12 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non
                   When it meets a record having fewer tokens than the length of the schema, \
                   sets ``null`` to extra fields. When the record has more tokens than the \
                   length of the schema, it drops extra tokens.
-                * ``DROPMALFORMED`` : ignores the whole corrupted records.
+                * ``DROPMALFORMED`` : ignores the whole corrupted records. Note that when CSV \
+                  parser column pruning (``spark.sql.csv.parser.columnPruning.enabled``) is enabled \
 
 Review comment:
   One concern is that `spark.sql.csv.parser.columnPruning.enabled` is internal config. I'm not sure if there is policy that we shouldn't mention internal config in doc.
   
   cc @HyukjinKwon @dongjoon-hyun 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org