You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sebastian Geller <in...@cmb-tradecenter.org> on 2014/06/11 23:34:10 UTC

Review Request 22479: Patch for KAFKA-1291

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22479/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1291
    https://issues.apache.org/jira/browse/KAFKA-1291


Repository: kafka


Description
-------

fixed typo for windows java heap options


Diffs
-----

  bin/kafka-consumer-offset-checker.sh PRE-CREATION 
  bin/kafka-get-partition-offset-shell.sh PRE-CREATION 
  bin/kafka-mirror-maker.sh PRE-CREATION 
  bin/kafka-replica-verification.sh PRE-CREATION 
  bin/kafka-verify-consumer-rebalance.sh PRE-CREATION 
  bin/windows/kafka-consumer-offset-checker.bat PRE-CREATION 
  bin/windows/kafka-consumer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-get-partition-offset-shell.bat PRE-CREATION 
  bin/windows/kafka-mirror-maker.bat PRE-CREATION 
  bin/windows/kafka-preferred-replica-election.bat PRE-CREATION 
  bin/windows/kafka-producer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-reassign-partitions.bat PRE-CREATION 
  bin/windows/kafka-replay-log-producer.bat PRE-CREATION 
  bin/windows/kafka-replica-verification.bat PRE-CREATION 
  bin/windows/kafka-simple-consumer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-simple-consumer-shell.bat PRE-CREATION 
  bin/windows/kafka-verify-consumer-rebalance.bat PRE-CREATION 
  bin/windows/zookeeper-shell.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/22479/diff/


Testing
-------


Thanks,

Sebastian Geller


Re: Review Request 22479: KAFKA-1291: Make wrapper shell scripts for important tools

Posted by Sebastian Geller <in...@cmb-tradecenter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22479/
-----------------------------------------------------------

(Updated June 11, 2014, 9:38 p.m.)


Review request for kafka.


Changes
-------

Updated description.


Summary (updated)
-----------------

KAFKA-1291: Make wrapper shell scripts for important tools


Bugs: KAFKA-1291
    https://issues.apache.org/jira/browse/KAFKA-1291


Repository: kafka


Description (updated)
-------

- Added wrapper scripts for most of the tools
- Added and updated windows wrapper scripts

Is this patch missing any important tool?


Diffs
-----

  bin/kafka-consumer-offset-checker.sh PRE-CREATION 
  bin/kafka-get-partition-offset-shell.sh PRE-CREATION 
  bin/kafka-mirror-maker.sh PRE-CREATION 
  bin/kafka-replica-verification.sh PRE-CREATION 
  bin/kafka-verify-consumer-rebalance.sh PRE-CREATION 
  bin/windows/kafka-consumer-offset-checker.bat PRE-CREATION 
  bin/windows/kafka-consumer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-get-partition-offset-shell.bat PRE-CREATION 
  bin/windows/kafka-mirror-maker.bat PRE-CREATION 
  bin/windows/kafka-preferred-replica-election.bat PRE-CREATION 
  bin/windows/kafka-producer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-reassign-partitions.bat PRE-CREATION 
  bin/windows/kafka-replay-log-producer.bat PRE-CREATION 
  bin/windows/kafka-replica-verification.bat PRE-CREATION 
  bin/windows/kafka-simple-consumer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-simple-consumer-shell.bat PRE-CREATION 
  bin/windows/kafka-verify-consumer-rebalance.bat PRE-CREATION 
  bin/windows/zookeeper-shell.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/22479/diff/


Testing (updated)
-------

- Executed all scripts on unix and windows


Thanks,

Sebastian Geller