You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/11 05:58:59 UTC
[GitHub] [flink] SteNicholas opened a new pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
SteNicholas opened a new pull request #14028:
URL: https://github.com/apache/flink/pull/14028
## What is the purpose of the change
*Currently, different implementations of the `JobClient` throw different exceptions. The `ClusterClientJobClientAdapter` wraps the exception from the `JobResult.toJobExecutionResult()` into a `ProgramInvocationException`, the `MiniClusterJobClient` simply wraps it in a `CompletionException` and the `EmbeddedJobClient` wraps it into an `UnsuccessfulExecutionException`. `JobResult.toJobExecutionResult()` should make the exception uniform and part of the contract through `JobExecutionResultException` which exception includes the status of the application.*
## Brief change log
- *Add `JobExecutionResultException` to make the exception uniform and part of the contract for `JobResult.toJobExecutionResult()`.*
- *`ClusterClientJobClientAdapter`, `MiniClusterJobClient` and `EmbeddedJobClient` uniform the exception to `JobExecutionResultException`.*
## Verifying this change
- *Modify `ApplicationDispatcherBootstrapTest` and `PerJobMiniClusterFactoryTest.java` to update the `UnsuccessfulExecutionException` check to the `JobExecutionResultException`.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-727921163
> @SteNicholas why not putting the `status` in the `JobExecutionException` and remove the `JobExecutionResultException`?
Because of the compatibility for the previous `JobExecutionException`. I have pushed commit that add the `status` to `JobExecutionException` to check wheter the commit could work. Please review this again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
* 7056c576682360f0f5b00705755894089341f665 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-737359487
Although the `ProgramInvocationException` is not annotated as `Public` or `PublicEvolving`, due to the fact that it has been here since forever, it seems that in some places we may be handling it specially and even expose it to the users. For example, the `ClientUtils.executeProgram()` is public and in the mailing list in the past there were people saying that they use it in other projects (I think Beam used to use it and I do not know if they still do).
On a separate note, given that this PR although small it has taken more than 3 weeks and a lot of discussions, I am starting to doubt if we should move forward with it. For example, the question that @tillrohrmann mentioned to have a separate exception for the runtime components and a separate for the client so that we can handle them differently, seems a deeper issue that requires more thought.
I may be wrong on that, but the discussions seem to be disproportionately long for the size and also the added value of this PR. What do you think?
BTW sorry for your time @SteNicholas if this does not get merged in the end but when I opened the JIRA I did not have a clear view of all the related changes that would pop up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-737624582
> example
@kl0u , IMO, I really want to follow the remaining comments from @tillrohrmann , and continue to update the commit according to Till's above comments. It's better for me to merge this pull request in the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8ed413c7c3c83f5e724e32aa17d2c20d751eea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508)
* 257753275bc370049438a58d129801888c1c6ddb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdc2dc09930a7064c55073381f0be79be0599d71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726)
* 4a912e52f9520467dcdc7eeb3a19937c331e99e3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-727142827
> I am having a look right now @SteNicholas
@kl0u Any other comments by you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a912e52f9520467dcdc7eeb3a19937c331e99e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737)
* ab8acbd972d3b45ab254da9d3229bcdacddc7c05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r534270664
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
In `MinCluster#executeJobBlocking`, if `JobResult#toJobExecutionResult` throws the `IOException`, the method would catch the `IOException` and throws the `JobExecutionException`. Meanwhile, the application status of `JobExecutionException` is `SUCCEEDED `. Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733034701
> 2\. ExecutionGraphBuilder
@tillrohrmann , thanks for your detailed review. My answer for above question you mentioned is as follows:
1.`ProgramInvocationException` isn't the part of the public API of a `JobClient`. Even if it is, it is wrapped into `CompletableFuture`.
2.Why the `JobExecutionException` is removed from the runtime components (specifically the `ExecutionGraphBuilder`)? What are the adverse effects of this？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7eeaee3de15449732a05aa075b10cbbf9e152c2a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477)
* cc8ed413c7c3c83f5e724e32aa17d2c20d751eea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
* 7056c576682360f0f5b00705755894089341f665 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466)
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-726624088
I am having a look right now @SteNicholas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r534245909
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
Wouldn't we then fail with an `IOException` being thrown from `JobResult#toJobExecutionResult`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a912e52f9520467dcdc7eeb3a19937c331e99e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737)
* ab8acbd972d3b45ab254da9d3229bcdacddc7c05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-728792980
thanks @SteNicholas , I will check your PR now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529622200
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
@tillrohrmann , no, there is a case that `jobResult.toJobExecutionResult` throws excepton with `SUCCEEDED` application status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731046963
@tillrohrmann , could you please review this pull request for the application status of `JobExecutionException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529620715
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java
##########
@@ -116,8 +115,7 @@ public JobID getJobID() {
try {
return jobResult.toJobExecutionResult(classLoader);
} catch (Throwable t) {
- throw new CompletionException(
- new ProgramInvocationException("Job failed", jobID, t));
Review comment:
@tillrohrmann , IMO, this is about the changes to `CompletionExcetpion` contract for `JobClient `, which maybe change much. @aljoscha Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725301089
@kl0u , could you please help to review this commit if you are available?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28acb4ec06f4d0da0a31aa5239c1575b19f112a6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687)
* cdc2dc09930a7064c55073381f0be79be0599d71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529595194
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -342,7 +343,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
Same here?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
Shouldn't we assert that `status` is not `SUCCEEDED`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
##########
@@ -221,7 +222,7 @@ public static ExecutionGraph buildGraph(
vertex.initializeOnMaster(classLoader);
}
catch (Throwable t) {
- throw new JobExecutionException(jobId,
+ throw new JobExecutionException(jobId, ApplicationStatus.fromJobStatus(executionGraph.getState()),
Review comment:
I think it is not correct to already decide on the `ApplicationStatus` here. If the initialization of the job fails, we might still be able to retry it. Maybe it would be better to not use the `JobExecutionException` across the client and server. Maybe it should stay a client side concept which is only thrown by the client when obtaining the job result.
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java
##########
@@ -116,8 +115,7 @@ public JobID getJobID() {
try {
return jobResult.toJobExecutionResult(classLoader);
} catch (Throwable t) {
- throw new CompletionException(
- new ProgramInvocationException("Job failed", jobID, t));
Review comment:
Aren't we changing here part of the public API by changing the return type of the exceptions? How much of a contract is it that the user of the JobClient expects an `ProgramInvocationException` @aljoscha?
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
Why is this change necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
* 7056c576682360f0f5b00705755894089341f665 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466)
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725901773
Hi @SteNicholas , I reviewing your PR now. One thing to add is some tests (for each client) that verify that all clients throw the expected type of exception. This is to make sure that no one breaks the contract in the future. Also this can become part of the javadoc of the `JobClient.getJobExecutionResult()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725301089
@kl0u , could you please help to review this commit if you are available?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533368608
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
Which case is this exactly? I thought that we would obtain a `JobExecutionResult` if the execution of the job was successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas closed pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas closed pull request #14028:
URL: https://github.com/apache/flink/pull/14028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733034701
> 2\. ExecutionGraphBuilder
@tillrohrmann
1.`ProgramInvocationException` isn't the part of the public API of a `JobClient`. Even if it is, it is wrapped into `CompletableFuture`.
2.Why the `JobExecutionException` is removed from the runtime components (specifically the `ExecutionGraphBuilder`)? What are the adverse effects of this？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525647349
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -669,13 +669,14 @@ public JobExecutionResult executeJobBlocking(JobGraph job) throws JobExecutionEx
try {
jobResult = jobResultFuture.get();
} catch (ExecutionException e) {
- throw new JobExecutionException(job.getJobID(), "Could not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
+ throw new JobExecutionException(job.getJobID(), ApplicationStatus.UNKNOWN,
+ "Could not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
}
try {
return jobResult.toJobExecutionResult(Thread.currentThread().getContextClassLoader());
} catch (IOException | ClassNotFoundException e) {
- throw new JobExecutionException(job.getJobID(), e);
+ throw new JobExecutionException(job.getJobID(), jobResult.getApplicationStatus(), e);
Review comment:
@kl0u IMO, I don't think this is misleading . The application status for this exception case is SUCCESS, but the exception means the deserialization of job result with an exception. We may add exception message to tell users that the application is succeeded but the deserialization with an exception. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725907605
> Hi @SteNicholas , I reviewing your PR now. One thing to add is some tests (for each client) that verify that all clients throw the expected type of exception. This is to make sure that no one breaks the contract in the future. Also this can become part of the javadoc of the `JobClient.getJobExecutionResult()`.
I forgot to add `JobExecutionResultException` contract to the javadoc of `JobClient.getJobExecutionResult()`. And about the tests, I thought that current test cases include the tests that verify that all clients throw the expected type of exception. But it's better to add tests for each client extrally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8ed413c7c3c83f5e724e32aa17d2c20d751eea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508)
* 257753275bc370049438a58d129801888c1c6ddb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28acb4ec06f4d0da0a31aa5239c1575b19f112a6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687)
* cdc2dc09930a7064c55073381f0be79be0599d71 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731046963
@tillrohrmann , could you please review this pull request and take a look at the [commit](https://github.com/kl0u/flink/tree/client-exception-fin) of @kl0u ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r527559495
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -669,13 +669,14 @@ public JobExecutionResult executeJobBlocking(JobGraph job) throws JobExecutionEx
try {
jobResult = jobResultFuture.get();
} catch (ExecutionException e) {
- throw new JobExecutionException(job.getJobID(), "Could not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
+ throw new JobExecutionException(job.getJobID(), ApplicationStatus.UNKNOWN,
+ "Could not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
}
try {
return jobResult.toJobExecutionResult(Thread.currentThread().getContextClassLoader());
} catch (IOException | ClassNotFoundException e) {
- throw new JobExecutionException(job.getJobID(), e);
+ throw new JobExecutionException(job.getJobID(), jobResult.getApplicationStatus(), e);
Review comment:
Maybe this is a nice middle ground @SteNicholas . Have the status as `SUCCESS` and a message that says that something went wrong during getting the result. As a sidenote, it may be that this could require a new type of exception in the future (not necessarily in this PR) as it seems that we are using the same exception for different purposes. One is successful job execution (or not) and the other is successful job result translation (or not).
This was also a discussion we had offline with @SteNicholas ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529613521
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
##########
@@ -221,7 +222,7 @@ public static ExecutionGraph buildGraph(
vertex.initializeOnMaster(classLoader);
}
catch (Throwable t) {
- throw new JobExecutionException(jobId,
+ throw new JobExecutionException(jobId, ApplicationStatus.fromJobStatus(executionGraph.getState()),
Review comment:
@tillrohrmann , what's the problem when using the `JobExecutionException` across the client and server?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab8acbd972d3b45ab254da9d3229bcdacddc7c05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7eeaee3de15449732a05aa075b10cbbf9e152c2a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-737624706
> Although the `ProgramInvocationException` is not annotated as `Public` or `PublicEvolving`, due to the fact that it has been here since forever, it seems that in some places we may be handling it specially and even expose it to the users. For example, the `ClientUtils.executeProgram()` is public and in the mailing list in the past there were people saying that they use it in other projects (I think Beam used to use it and I do not know if they still do).
>
> On a separate note, given that this PR although small it has taken more than 3 weeks and a lot of discussions, I am starting to doubt if we should move forward with it. For example, the question that @tillrohrmann mentioned to have a separate exception for the runtime components and a separate for the client so that we can handle them differently, seems a deeper issue that requires more thought.
>
> I may be wrong on that, but the discussions seem to be disproportionately long for the size and also the added value of this PR. What do you think?
>
> BTW sorry for your time @SteNicholas if this does not get merged in the end but when I opened the JIRA I did not have a clear view of all the related changes that would pop up.
@kl0u , IMO, I really want to follow the remaining comments from @tillrohrmann , and continue to update the commit according to Till's above comments. It's better for me to merge this pull request in the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
}, {
"hash" : "a711ce5736230806169b800574dccd387d7b66eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10465",
"triggerID" : "a711ce5736230806169b800574dccd387d7b66eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab8acbd972d3b45ab254da9d3229bcdacddc7c05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869)
* a711ce5736230806169b800574dccd387d7b66eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525224696
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,53 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
}
- public JobExecutionException(JobID jobID, String msg) {
Review comment:
Javadoc.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,53 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
}
- public JobExecutionException(JobID jobID, String msg) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg) {
super(msg);
this.jobID = jobID;
+ this.status = status;
}
- public JobExecutionException(JobID jobID, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, Throwable cause) {
Review comment:
Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533853218
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java
##########
@@ -116,8 +115,7 @@ public JobID getJobID() {
try {
return jobResult.toJobExecutionResult(classLoader);
} catch (Throwable t) {
- throw new CompletionException(
- new ProgramInvocationException("Job failed", jobID, t));
Review comment:
@tillrohrmann , I would wait for @aljoscha to give the opinion about the changes to `CompletionExcetpion` contract for `JobClient`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdc2dc09930a7064c55073381f0be79be0599d71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726)
* 4a912e52f9520467dcdc7eeb3a19937c331e99e3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529622200
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
@tillrohrmann , no, there is a case that `jobResult.toJobExecutionResult` throws excepton with SUCCESS application status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-736520139
Thanks for the update @SteNicholas. Before moving forward I would like to hear from someone involved in the public APIs, that the `ProgramInvocationException` is indeed not public. Moreover, I still believe that the `JobExecutionException` which now transports the final `ApplicationStatus` shouldn't be used within the runtime components. Instead it should be used to communicate a failed `ApplicationStatus` to the outside world.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-737624582
> example
@kl0u , IMO, I really want to follow the remaining comments from @tillrohrmann , and continue to update the commit according to Till's above comments. It's better for me to merge this pull request in the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468)
* 7eeaee3de15449732a05aa075b10cbbf9e152c2a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a912e52f9520467dcdc7eeb3a19937c331e99e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731067152
@tillrohrmann , could you please review this pull request for the application status of `JobExecutionException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533850366
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
@tillrohrmann , I got your point for this change, and I would like to update commit for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525017417
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResult.java
##########
@@ -133,26 +132,32 @@ public JobExecutionResult toJobExecutionResult(ClassLoader classLoader) throws J
accumulatorResults,
classLoader));
} else {
- final Throwable cause;
Review comment:
This `else {...}` block can now become simply:
`throw getJobExecutionException(serializedThrowable, classLoader);` right? We do not need to wrap the original exception anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529610196
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
@tillrohrmann , because this change checks whether the application status is FAILED. Only when application status is FAILED, this could throw Exception with fail message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529610196
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
@tillrohrmann , because this change checks whether the application status is FAILED. Only when application status is FAILED not CANCELED, this could throw Exception with fail message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8ed413c7c3c83f5e724e32aa17d2c20d751eea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7056c576682360f0f5b00705755894089341f665 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466)
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdc2dc09930a7064c55073381f0be79be0599d71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525017417
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResult.java
##########
@@ -133,26 +132,32 @@ public JobExecutionResult toJobExecutionResult(ClassLoader classLoader) throws J
accumulatorResults,
classLoader));
} else {
- final Throwable cause;
Review comment:
This `else()` block can now become simply:
`throw getJobExecutionException(serializedThrowable, classLoader);` right? We do not need to wrap the original exception anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 28acb4ec06f4d0da0a31aa5239c1575b19f112a6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731067152
@tillrohrmann , could you please review this pull request for the application status of `JobExecutionException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725983640
> Hi @SteNicholas , I have a commit with my comments here https://github.com/apache/flink/tree/client-exception. Also for the tests I think we should just add tests for all the cases in the `JobResultTest`. What do you think?
@kl0u Your implementation is better for me than my bad implementation. And the test cases look clear for each client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529612466
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
I think if program throws a `JobCancellationException`, then we don't set it in the `errorRef` variable. Hence, this test should not be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
* 7056c576682360f0f5b00705755894089341f665 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725986904
Thanks a lot @SteNicholas. Feel free to take the commit and integrate it in your PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725219422
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0e105679613efd2a1ccc80b678445bbcc23042cb (Wed Nov 11 06:01:14 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731046963
@tillrohrmann , could you please review this pull request ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7eeaee3de15449732a05aa075b10cbbf9e152c2a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477)
* cc8ed413c7c3c83f5e724e32aa17d2c20d751eea UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525220074
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -669,13 +669,14 @@ public JobExecutionResult executeJobBlocking(JobGraph job) throws JobExecutionEx
try {
jobResult = jobResultFuture.get();
} catch (ExecutionException e) {
- throw new JobExecutionException(job.getJobID(), "Could not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
+ throw new JobExecutionException(job.getJobID(), ApplicationStatus.UNKNOWN,
+ "Could not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
}
try {
return jobResult.toJobExecutionResult(Thread.currentThread().getContextClassLoader());
} catch (IOException | ClassNotFoundException e) {
- throw new JobExecutionException(job.getJobID(), e);
+ throw new JobExecutionException(job.getJobID(), jobResult.getApplicationStatus(), e);
Review comment:
Can this be misleading? For example the application was successful but it failed to deserialize the result so now we have status `SUCCEEDED` but with an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-731046963
@tillrohrmann , could you please review this pull request for the application status of `JobExecutionException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-728205825
@SteNicholas I had a look at this solution and I would like to think on how to make the `status` `final`. This means that I am trying to see if we can have all the `JobExecutionExceptions` with a `status`. I will get back with more comments tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529610784
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -342,7 +343,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
@tillrohrmann The same to above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
}, {
"hash" : "a711ce5736230806169b800574dccd387d7b66eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a711ce5736230806169b800574dccd387d7b66eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab8acbd972d3b45ab254da9d3229bcdacddc7c05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869)
* a711ce5736230806169b800574dccd387d7b66eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-737624706
> Although the `ProgramInvocationException` is not annotated as `Public` or `PublicEvolving`, due to the fact that it has been here since forever, it seems that in some places we may be handling it specially and even expose it to the users. For example, the `ClientUtils.executeProgram()` is public and in the mailing list in the past there were people saying that they use it in other projects (I think Beam used to use it and I do not know if they still do).
>
> On a separate note, given that this PR although small it has taken more than 3 weeks and a lot of discussions, I am starting to doubt if we should move forward with it. For example, the question that @tillrohrmann mentioned to have a separate exception for the runtime components and a separate for the client so that we can handle them differently, seems a deeper issue that requires more thought.
>
> I may be wrong on that, but the discussions seem to be disproportionately long for the size and also the added value of this PR. What do you think?
>
> BTW sorry for your time @SteNicholas if this does not get merged in the end but when I opened the JIRA I did not have a clear view of all the related changes that would pop up.
@kl0u , I have followed with the `KafkaConsumerTestBase` comment from @tillrohrmann and pushed a commit for this. And I really want to follow the remaining comments from @tillrohrmann , and continue to update the commit according to Till's above comments. It's better for me to merge this pull request in the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
}, {
"hash" : "a711ce5736230806169b800574dccd387d7b66eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10465",
"triggerID" : "a711ce5736230806169b800574dccd387d7b66eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a711ce5736230806169b800574dccd387d7b66eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-728748152
> @SteNicholas I had a look at this solution and I would like to think on how to make the `status` `final`. This means that I am trying to see if we can have all the `JobExecutionExceptions` with a `status`. I will get back with more comments tomorrow.
As you mentioned, all the `JobExecutionExceptions` could be with a given `status`. I have tried to make `status` final and updated `JobCancellationException`, `JobInitializationException` and `JobSubmissionException`. IMO, the `status` of `JobInitializationException` and `JobSubmissionException` is UNKNOWN, and the `status` of `JobCancellationException` is CANCELLED. Please check this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725908109
Also why not putting the logic directly in the `JobResult.toJobExecutionResult()`, instead of keeping it separately to each client? This will lead to more robust code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458)
* 7056c576682360f0f5b00705755894089341f665 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466)
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733035458
> Thanks for creating this PR @SteNicholas. In general I like the unification of thrown exception. I had two questions:
>
> 1. Is the `ProgramInvocationException` part of the public API of a `JobClient`?
> 2. Can we remove the `JobExecutionException` from the runtime components (specifically the `ExecutionGraphBuilder`)?
@tillrohrmann , thanks for your detailed review. My answer for above question you mentioned is as follows:
1.ProgramInvocationException isn't the part of the public API of a JobClient. Even if it is, it is wrapped into CompletableFuture.
2.Why the JobExecutionException is removed from the runtime components (specifically the ExecutionGraphBuilder)? What are the adverse effects of this？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533853218
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java
##########
@@ -116,8 +115,7 @@ public JobID getJobID() {
try {
return jobResult.toJobExecutionResult(classLoader);
} catch (Throwable t) {
- throw new CompletionException(
- new ProgramInvocationException("Job failed", jobID, t));
Review comment:
@tillrohrmann , I would wait for @aljoscha to give the opinion of the changes to `CompletionExcetpion` contract for `JobClient`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
}, {
"hash" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9726",
"triggerID" : "cdc2dc09930a7064c55073381f0be79be0599d71",
"triggerType" : "PUSH"
}, {
"hash" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9737",
"triggerID" : "4a912e52f9520467dcdc7eeb3a19937c331e99e3",
"triggerType" : "PUSH"
}, {
"hash" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9869",
"triggerID" : "ab8acbd972d3b45ab254da9d3229bcdacddc7c05",
"triggerType" : "PUSH"
}, {
"hash" : "a711ce5736230806169b800574dccd387d7b66eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10465",
"triggerID" : "a711ce5736230806169b800574dccd387d7b66eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a711ce5736230806169b800574dccd387d7b66eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10465)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733034701
> 2\. ExecutionGraphBuilder
@tillrohrmann , thanks for your detailed review. My answer for above question you mentioned is as follows:
1.`ProgramInvocationException` isn't the part of the public API of a `JobClient`. Even if it is, it is wrapped into `CompletableFuture`.
2.Why the `JobExecutionException` is removed from the runtime components (specifically the `ExecutionGraphBuilder`)? What are the adverse effects of this？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533368080
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
##########
@@ -221,7 +222,7 @@ public static ExecutionGraph buildGraph(
vertex.initializeOnMaster(classLoader);
}
catch (Throwable t) {
- throw new JobExecutionException(jobId,
+ throw new JobExecutionException(jobId, ApplicationStatus.fromJobStatus(executionGraph.getState()),
Review comment:
One problem is that we are specifying the "final" application status for the `JobExecutionException` here. I think this is wrong since `executionGraph.getState()` could also be something different than a globally terminal state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 257753275bc370049438a58d129801888c1c6ddb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634)
* 28acb4ec06f4d0da0a31aa5239c1575b19f112a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9687)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533368963
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientJobClientAdapter.java
##########
@@ -116,8 +115,7 @@ public JobID getJobID() {
try {
return jobResult.toJobExecutionResult(classLoader);
} catch (Throwable t) {
- throw new CompletionException(
- new ProgramInvocationException("Job failed", jobID, t));
Review comment:
I'd like to hear the opinion of someone involved in the APIs of Flink before making any decisions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-727921163
> @SteNicholas why not putting the `status` in the `JobExecutionException` and remove the `JobExecutionResultException`?
@kl0u Because of the compatibility for the previous `JobExecutionException`. I have pushed commit that add the `status` to `JobExecutionException` to check wheter the commit could work. Please review this again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
}, {
"hash" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "28acb4ec06f4d0da0a31aa5239c1575b19f112a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 257753275bc370049438a58d129801888c1c6ddb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634)
* 28acb4ec06f4d0da0a31aa5239c1575b19f112a6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-727142827
> I am having a look right now @SteNicholas
@kl0u Any other comments by you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdb2e0c536ee9c0cdf45bdcee495ba7397887df2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468)
* 7eeaee3de15449732a05aa075b10cbbf9e152c2a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9458",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
}, {
"hash" : "7056c576682360f0f5b00705755894089341f665",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9466",
"triggerID" : "7056c576682360f0f5b00705755894089341f665",
"triggerType" : "PUSH"
}, {
"hash" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9468",
"triggerID" : "bdb2e0c536ee9c0cdf45bdcee495ba7397887df2",
"triggerType" : "PUSH"
}, {
"hash" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9477",
"triggerID" : "7eeaee3de15449732a05aa075b10cbbf9e152c2a",
"triggerType" : "PUSH"
}, {
"hash" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9508",
"triggerID" : "cc8ed413c7c3c83f5e724e32aa17d2c20d751eea",
"triggerType" : "PUSH"
}, {
"hash" : "257753275bc370049438a58d129801888c1c6ddb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634",
"triggerID" : "257753275bc370049438a58d129801888c1c6ddb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 257753275bc370049438a58d129801888c1c6ddb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9634)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733024298
To me it looks good! So I think we can change it. However, it's still not optimal for users because `JobExecutionException` is not really a user-facing exception, it's defined in the `flink-runtime` package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533851974
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
@tillrohrmann , the case is that the execution of the job is successful, but calls `AccumulatorHelper.deserializeAccumulators` throws Exception when calling `jobResult.toJobExecutionResult`. In this case the application status is `SUCCEEDED `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-736948175
Thanks for @tillrohrmann detailed review reply. I agree with the point that `JobExecutionException` transporting the final `ApplicationStatus` shouldn't be used within the runtime components. I would change the commit in `ExecutionGraphBuilder` to remove the `JobExecutionException` from `runtime ` components.
BTW, @aljoscha , could you please give your opinion about the changes to `CompletionExcetpion` contract for `JobClient`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725959233
Hi @SteNicholas , I have a commit with my comments here https://github.com/apache/flink/tree/client-exception. Also for the tests I think we should just add tests for all the cases in the `JobResultTest`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-726555110
> Thanks a lot @SteNicholas. Feel free to take the commit and integrate it in your PR :)
@kl0u Thanks for you better implementation commit. I have integrated into my pull request. Please help to review again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-725222918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443",
"triggerID" : "0e105679613efd2a1ccc80b678445bbcc23042cb",
"triggerType" : "PUSH"
}, {
"hash" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5690cd480e595dccffb3584f82edfda70caa89cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e105679613efd2a1ccc80b678445bbcc23042cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9443)
* 5690cd480e595dccffb3584f82edfda70caa89cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533851974
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobExecutionException.java
##########
@@ -19,41 +19,67 @@
package org.apache.flink.runtime.client;
import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
import org.apache.flink.util.FlinkException;
/**
* This exception is the base exception for all exceptions that denote any failure during
- * the execution of a job.
+ * the execution of a job, and signal the failure of an application with a given
+ * {@link ApplicationStatus}.
*/
public class JobExecutionException extends FlinkException {
private static final long serialVersionUID = 2818087325120827525L;
private final JobID jobID;
+ private final ApplicationStatus status;
+
/**
* Constructs a new job execution exception.
*
- * @param jobID The job's ID.
- * @param msg The cause for the execution exception.
- * @param cause The cause of the exception
+ * @param jobID The job's ID.
+ * @param status The application status.
+ * @param msg The cause for the execution exception.
+ * @param cause The cause of the exception
*/
- public JobExecutionException(JobID jobID, String msg, Throwable cause) {
+ public JobExecutionException(JobID jobID, ApplicationStatus status, String msg, Throwable cause) {
super(msg, cause);
this.jobID = jobID;
+ this.status = status;
Review comment:
@tillrohrmann , the case is that the execution of the job is successful, but calls `AccumulatorHelper.deserializeAccumulators` throws Exception while calling `jobResult.toJobExecutionResult`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525646088
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResult.java
##########
@@ -133,26 +132,32 @@ public JobExecutionResult toJobExecutionResult(ClassLoader classLoader) throws J
accumulatorResults,
classLoader));
} else {
- final Throwable cause;
Review comment:
@kl0u Yes, your point is right for me. I forgot to remove the unnecessary wrapper for `JobExecutionException`. I would like to remove this wrapper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org