You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/04 12:22:10 UTC

[GitHub] [apisix-ingress-controller] huahu0213 opened a new pull request #238: Branch master issue228

huahu0213 opened a new pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
      New feature provided
   
   - Related issues
      Version information should be shown when the program started #228
   
   ### New feature or improvement
   - When apisix ingress controller started, print the "version.Short()" information
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #238: Branch master issue228

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-773315298


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=h1) Report
   > Merging [#238](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=desc) (2cd4a16) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c786e083d3dc9bc4b1e8c2e2b9e7a099da6c88e5?el=desc) (c786e08) will **increase** coverage by `0.10%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #238      +/-   ##
   ==========================================
   + Coverage   44.48%   44.59%   +0.10%     
   ==========================================
     Files          34       33       -1     
     Lines        2050     2052       +2     
   ==========================================
   + Hits          912      915       +3     
   + Misses        995      994       -1     
     Partials      143      143              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `71.21% <100.00%> (+0.44%)` | :arrow_up: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `80.89% <0.00%> (+0.21%)` | :arrow_up: |
   | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `39.45% <0.00%> (+0.41%)` | :arrow_up: |
   | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `67.27% <0.00%> (+0.90%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=footer). Last update [c786e08...2cd4a16](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-773723254


   @huahu0213 Please merge the newest master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#discussion_r570651498



##########
File path: cmd/ingress/ingress.go
##########
@@ -96,6 +97,8 @@ the apisix cluster and others are created`,
 			log.DefaultLogger = logger
 			log.Info("apisix ingress controller started")
 
+			log.Info("version: ", version.Short())

Review comment:
       I think here output the long version is better :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-774403567


   @huahu0213 Merged and thanks for your good job!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-773714707


   e2e test failed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers merged pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
tokers merged pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-773723254


   @huahu0213 Please merge the newest master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#discussion_r570651498



##########
File path: cmd/ingress/ingress.go
##########
@@ -96,6 +97,8 @@ the apisix cluster and others are created`,
 			log.DefaultLogger = logger
 			log.Info("apisix ingress controller started")
 
+			log.Info("version: ", version.Short())

Review comment:
       I think here output the long version is better :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] huahu0213 commented on a change in pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
huahu0213 commented on a change in pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#discussion_r570660246



##########
File path: cmd/ingress/ingress.go
##########
@@ -96,6 +97,8 @@ the apisix cluster and others are created`,
 			log.DefaultLogger = logger
 			log.Info("apisix ingress controller started")
 
+			log.Info("version: ", version.Short())

Review comment:
       OK，I will deal with this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #238: Branch master issue228

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-773315298


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=h1) Report
   > Merging [#238](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=desc) (2cd4a16) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c786e083d3dc9bc4b1e8c2e2b9e7a099da6c88e5?el=desc) (c786e08) will **increase** coverage by `0.10%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #238      +/-   ##
   ==========================================
   + Coverage   44.48%   44.59%   +0.10%     
   ==========================================
     Files          34       33       -1     
     Lines        2050     2052       +2     
   ==========================================
   + Hits          912      915       +3     
   + Misses        995      994       -1     
     Partials      143      143              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `71.21% <100.00%> (+0.44%)` | :arrow_up: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `80.89% <0.00%> (+0.21%)` | :arrow_up: |
   | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `39.45% <0.00%> (+0.41%)` | :arrow_up: |
   | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `67.27% <0.00%> (+0.90%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=footer). Last update [c786e08...2cd4a16](https://codecov.io/gh/apache/apisix-ingress-controller/pull/238?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] huahu0213 commented on a change in pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
huahu0213 commented on a change in pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#discussion_r570660246



##########
File path: cmd/ingress/ingress.go
##########
@@ -96,6 +97,8 @@ the apisix cluster and others are created`,
 			log.DefaultLogger = logger
 			log.Info("apisix ingress controller started")
 
+			log.Info("version: ", version.Short())

Review comment:
       OK，I will deal with this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #238: feat : Shown version information when the program started

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #238:
URL: https://github.com/apache/apisix-ingress-controller/pull/238#issuecomment-773714707


   e2e test failed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org