You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by GitBox <gi...@apache.org> on 2021/01/15 16:27:26 UTC
[GitHub] [archiva] elukey opened a new pull request #61: Avoid Jetty's default directory listing settings in web.xml
elukey opened a new pull request #61:
URL: https://github.com/apache/archiva/pull/61
The directory listing servlet seems not be needed for the default
settings. This change explicitly sets it off in web.xml.
Credis to @jobar for the original change made for Wikimedia.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] effrafax edited a comment on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
effrafax edited a comment on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761847738
I merged your change to the master and archiva-2.x branch.
Thank You for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] elukey edited a comment on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
elukey edited a comment on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761822816
@effrafax Hi! In our use case the DefaultServlet was active (we don't change web.xml, we use the one shipped with the Archiva's standalone release tarball), and we had to explicitly turn it off with the above setting (that also avoid it being loaded during startup). There are some interesting things that one can do using Jetty and the DefaultServlet, a colleague of mine should have already reached out to follow up a couple of days ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] elukey commented on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761757664
Hi! Any feedback on this pull request? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] elukey edited a comment on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
elukey edited a comment on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761822816
@effrafax Hi! In our use case the DefaultServlet was active (we don't change web.xml, we use the one shipped with the Archiva's standalone release tarball), and we had to explicitly turn it off with the above setting (that also avoid it being loaded during startup). There are some interesting things that one can do using Jetty and the DefaultServlet, a colleague of mine should have already reached out to follow up a couple of days ago.
The task that we opened should be public, more info about our use case in https://phabricator.wikimedia.org/T272082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] effrafax closed pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
effrafax closed pull request #61:
URL: https://github.com/apache/archiva/pull/61
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] elukey commented on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761822816
@effrafax Hi! In our use case without the above settings the DefaultServlet was active, and we had to explicitly turn it off with the above setting (that also avoid it being loaded during startup). There are some interesting things that one can do using Jetty and the DefaultServlet, a colleague of mine should have already reached out to follow up a couple of days ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] effrafax commented on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
effrafax commented on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761847738
I merged your change to the master and archiva-2.x branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] effrafax commented on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
effrafax commented on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761813052
Hi @elukey,
can you explain the use case of your change in more detail? As I see it, the DefaultServlet was not active before. So why should we activate it and set dirAllowed to false? Cannot see the benefit of this.
Regards
Martin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [archiva] elukey commented on pull request #61: Avoid Jetty's default directory listing settings in web.xml
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #61:
URL: https://github.com/apache/archiva/pull/61#issuecomment-761850089
Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org