You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/21 01:29:37 UTC
[GitHub] HyukjinKwon edited a comment on issue #20125: [SPARK-17967][SQL]
Support for array as an option in SQL parser
HyukjinKwon edited a comment on issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL parser
URL: https://github.com/apache/spark/pull/20125#issuecomment-449204019
I was thinking about @cloud-fan's suggestion at https://github.com/apache/spark/pull/21192#issuecomment-391405633, and it looks feasible that we can additionally add an util that parses JSON array string to return an array but I wonder if that's possible in Data Source V1.
We can do that `DataSourceOptions.getArrays` for Data source V2. `DataSourceOptions.paths` uses a similar approach.
However, I don't think it's quite possible to Data Source V1, since we can't change the signatures from `Map[String, String]` to another.
Anyway I think we still need this change to follow @cloud-fan's suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org