You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/09/11 22:49:50 UTC
Review Request 25553: Views : Extract System view on ambari-server
setup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25553/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: ambari-7227
https://issues.apache.org/jira/browse/ambari-7227
Repository: ambari
Description
-------
Views marked as system views should be extracted as part of the 'ambari-server setup' command. This means that the system views (along with any other views that are already extracted) can be loaded immediately. Views not already extracted on startup will be loaded in the backgroud.
I think this should occur near the end of setup (i.e. after the database step -- the final step before completing setup).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 509e474
ambari-server/src/main/python/ambari-server.py 35ba17b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java f6a49cf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java eb4ef9c
ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 38c2f9b
ambari-server/src/test/python/TestAmbariServer.py 53f0ba1
Diff: https://reviews.apache.org/r/25553/diff/
Testing
-------
Manual testing.
Unit tests added. All existing tests pass.
Results :
Tests run: 1979, Failures: 0, Errors: 0, Skipped: 16
…
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:18.051s
[INFO] Finished at: Thu Sep 11 14:58:09 EDT 2014
[INFO] Final Memory: 28M/201M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 25553: Views : Extract System view on
ambari-server setup
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25553/#review53135
-----------------------------------------------------------
Ship it!
- Alejandro Fernandez
On Sept. 11, 2014, 8:49 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25553/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 8:49 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: ambari-7227
> https://issues.apache.org/jira/browse/ambari-7227
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Views marked as system views should be extracted as part of the 'ambari-server setup' command. This means that the system views (along with any other views that are already extracted) can be loaded immediately. Views not already extracted on startup will be loaded in the backgroud.
>
> I think this should occur near the end of setup (i.e. after the database step -- the final step before completing setup).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 509e474
> ambari-server/src/main/python/ambari-server.py 35ba17b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java f6a49cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java eb4ef9c
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 38c2f9b
> ambari-server/src/test/python/TestAmbariServer.py 53f0ba1
>
> Diff: https://reviews.apache.org/r/25553/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests added. All existing tests pass.
>
> Results :
>
> Tests run: 1979, Failures: 0, Errors: 0, Skipped: 16
>
> …
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.051s
> [INFO] Finished at: Thu Sep 11 14:58:09 EDT 2014
> [INFO] Final Memory: 28M/201M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25553: Views : Extract System view on
ambari-server setup
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25553/#review53176
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Sept. 11, 2014, 4:49 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25553/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 4:49 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: ambari-7227
> https://issues.apache.org/jira/browse/ambari-7227
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Views marked as system views should be extracted as part of the 'ambari-server setup' command. This means that the system views (along with any other views that are already extracted) can be loaded immediately. Views not already extracted on startup will be loaded in the backgroud.
>
> I think this should occur near the end of setup (i.e. after the database step -- the final step before completing setup).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 509e474
> ambari-server/src/main/python/ambari-server.py 35ba17b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java f6a49cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java eb4ef9c
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 38c2f9b
> ambari-server/src/test/python/TestAmbariServer.py 53f0ba1
>
> Diff: https://reviews.apache.org/r/25553/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests added. All existing tests pass.
>
> Results :
>
> Tests run: 1979, Failures: 0, Errors: 0, Skipped: 16
>
> …
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.051s
> [INFO] Finished at: Thu Sep 11 14:58:09 EDT 2014
> [INFO] Final Memory: 28M/201M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25553: Views : Extract System view on
ambari-server setup
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Sept. 11, 2014, 9:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari-server.py, line 192
> > <https://reviews.apache.org/r/25553/diff/1/?file=686511#file686511line192>
> >
> > If this class is moved, things are going to break. Hmmnnn, is there a good way to handle this?
Thanks for reviewing.
True, but the same also applies to every other java command line that we run from ambari-server.py including "org.apache.ambari.server.controller.AmbariServer". I think that it's okay to say that the script has to be in sync with the classes that it's shipped with. If the class package changes then so should the script for that release.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25553/#review53118
-----------------------------------------------------------
On Sept. 11, 2014, 8:49 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25553/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 8:49 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: ambari-7227
> https://issues.apache.org/jira/browse/ambari-7227
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Views marked as system views should be extracted as part of the 'ambari-server setup' command. This means that the system views (along with any other views that are already extracted) can be loaded immediately. Views not already extracted on startup will be loaded in the backgroud.
>
> I think this should occur near the end of setup (i.e. after the database step -- the final step before completing setup).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 509e474
> ambari-server/src/main/python/ambari-server.py 35ba17b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java f6a49cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java eb4ef9c
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 38c2f9b
> ambari-server/src/test/python/TestAmbariServer.py 53f0ba1
>
> Diff: https://reviews.apache.org/r/25553/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests added. All existing tests pass.
>
> Results :
>
> Tests run: 1979, Failures: 0, Errors: 0, Skipped: 16
>
> …
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.051s
> [INFO] Finished at: Thu Sep 11 14:58:09 EDT 2014
> [INFO] Final Memory: 28M/201M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25553: Views : Extract System view on
ambari-server setup
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Sept. 11, 2014, 9:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari-server.py, line 192
> > <https://reviews.apache.org/r/25553/diff/1/?file=686511#file686511line192>
> >
> > If this class is moved, things are going to break. Hmmnnn, is there a good way to handle this?
>
> Tom Beerbower wrote:
> Thanks for reviewing.
>
> True, but the same also applies to every other java command line that we run from ambari-server.py including "org.apache.ambari.server.controller.AmbariServer". I think that it's okay to say that the script has to be in sync with the classes that it's shipped with. If the class package changes then so should the script for that release.
Makes sense, should we start defining these as constants somewhere?
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25553/#review53118
-----------------------------------------------------------
On Sept. 11, 2014, 8:49 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25553/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 8:49 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: ambari-7227
> https://issues.apache.org/jira/browse/ambari-7227
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Views marked as system views should be extracted as part of the 'ambari-server setup' command. This means that the system views (along with any other views that are already extracted) can be loaded immediately. Views not already extracted on startup will be loaded in the backgroud.
>
> I think this should occur near the end of setup (i.e. after the database step -- the final step before completing setup).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 509e474
> ambari-server/src/main/python/ambari-server.py 35ba17b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java f6a49cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java eb4ef9c
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 38c2f9b
> ambari-server/src/test/python/TestAmbariServer.py 53f0ba1
>
> Diff: https://reviews.apache.org/r/25553/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests added. All existing tests pass.
>
> Results :
>
> Tests run: 1979, Failures: 0, Errors: 0, Skipped: 16
>
> …
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.051s
> [INFO] Finished at: Thu Sep 11 14:58:09 EDT 2014
> [INFO] Final Memory: 28M/201M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25553: Views : Extract System view on
ambari-server setup
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25553/#review53118
-----------------------------------------------------------
ambari-server/src/main/python/ambari-server.py
<https://reviews.apache.org/r/25553/#comment92531>
If this class is moved, things are going to break. Hmmnnn, is there a good way to handle this?
- Alejandro Fernandez
On Sept. 11, 2014, 8:49 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25553/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 8:49 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: ambari-7227
> https://issues.apache.org/jira/browse/ambari-7227
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Views marked as system views should be extracted as part of the 'ambari-server setup' command. This means that the system views (along with any other views that are already extracted) can be loaded immediately. Views not already extracted on startup will be loaded in the backgroud.
>
> I think this should occur near the end of setup (i.e. after the database step -- the final step before completing setup).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 509e474
> ambari-server/src/main/python/ambari-server.py 35ba17b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java f6a49cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java eb4ef9c
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 38c2f9b
> ambari-server/src/test/python/TestAmbariServer.py 53f0ba1
>
> Diff: https://reviews.apache.org/r/25553/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Unit tests added. All existing tests pass.
>
> Results :
>
> Tests run: 1979, Failures: 0, Errors: 0, Skipped: 16
>
> …
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:18.051s
> [INFO] Finished at: Thu Sep 11 14:58:09 EDT 2014
> [INFO] Final Memory: 28M/201M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>