You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/17 08:49:07 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8445:
[FLINK-12127][network,
config] Move network related options form TaskManagerOptions and NettyConfig
into NetworkEnvironmentOptions
zhijiangW commented on a change in pull request #8445: [FLINK-12127][network,config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions
URL: https://github.com/apache/flink/pull/8445#discussion_r285032347
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -97,6 +97,21 @@
" different TaskManagers need different values for this option, usually it is specified in an" +
" additional non-shared TaskManager-specific config file.");
+ /**
Review comment:
Ok, I could revert this change.
Just because it was in the network section, and after I migrated the network section out, it seems exist lonely. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services