You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Mark Thomas (JIRA)" <ji...@apache.org> on 2013/12/03 10:38:35 UTC

[jira] [Resolved] (DBCP-384) PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile

     [ https://issues.apache.org/jira/browse/DBCP-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Thomas resolved DBCP-384.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

API changed so this will only be fixed in 2.0 onwards.

> PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile
> -------------------------------------------------------------------
>
>                 Key: DBCP-384
>                 URL: https://issues.apache.org/jira/browse/DBCP-384
>             Project: Commons Dbcp
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 2.0
>
>
> The field PoolingDriver.accessToUnderlyingConnectionAllowed is static but mutable; this is inherently thread-hostile.
> It seems completely unnecessary for the field to be static; surely it could be an instance variable?
> Better yet, drop the setter/getter and make the field final, set by the ctor.



--
This message was sent by Atlassian JIRA
(v6.1#6144)