You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/07 07:32:47 UTC
[GitHub] [spark] sarutak opened a new pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
sarutak opened a new pull request #32078:
URL: https://github.com/apache/spark/pull/32078
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR removes the workaround for SPARK-34762.
After SPARK-34959 (#32055) is merged, that issue seems to go away.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To remove unnecessary workaround.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I confirmed the build pass on my laptop with the following commands.
```
find ~/.cache -path "commons*" -exec rm -rf {} \;
find ~/.m2 -path "commons*" -exec rm -rf {} \;
find ~/.ivy2 -path "commons*" -exec rm -rf {} \;
/build/sbt -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Phadoop-2.7 compile test:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815056094
Ur, Scala 2.13 build seems to fail on this PR, @sarutak . Could you take a look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-814823461
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137018/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-814862157
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815103666
Seems the same issue of commons.cli?
```
error: package org.apache.commons.cli does not exist
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-814820915
**[Test build #137018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137018/testReport)** for PR 32078 at commit [`f830c80`](https://github.com/apache/spark/commit/f830c8008e847aed5591f6984f040423d8497fa9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815374156
Got it. Thank you for keeping your eyes on it, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815368062
Hmm, it passed on my laptop but I must miss something.
Anyway, we seems to still need this workaround so I'll close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-814704107
**[Test build #137018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137018/testReport)** for PR 32078 at commit [`f830c80`](https://github.com/apache/spark/commit/f830c8008e847aed5591f6984f040423d8497fa9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-814704107
**[Test build #137018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137018/testReport)** for PR 32078 at commit [`f830c80`](https://github.com/apache/spark/commit/f830c8008e847aed5591f6984f040423d8497fa9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815416885
Thanks guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815368062
Hmm, it passed on my laptop but I must miss something.
Anyway, we seem to still need this workaround so I'll close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-814837548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #32078:
URL: https://github.com/apache/spark/pull/32078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32078: [SPARK-34762][BUILD][FOLLOWUP] Remove the workaround for SPARK-34762
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32078:
URL: https://github.com/apache/spark/pull/32078#issuecomment-815056094
Ur, Scala 2.13 build seems to fail on this PR, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org