[GitHub] [metron] sardell opened a new pull request #1550: METRON-2304: Update node and npm version to LTS releases

[GitBox <gi...@apache.org>]

sardell opened a new pull request #1550: METRON-2304: Update node and npm version to LTS releases
URL: https://github.com/apache/metron/pull/1550
 
 
   ## Contributor Comments
   Link to ASF ticket here: https://issues.apache.org/jira/browse/METRON-2304
   
   We are currently using node 9.11.1 and npm 6.2.0 in the project (this is specified in both the Alerts UI and Management UI pom.xml files). This version of node is no longer supported. Per Node.js' documents, "Production applications should only use Active LTS or Maintenance LTS releases." 
   
   In this PR, I updated the project to use the current active LTS release (10.17.0). I also updated the npm version to the latest minor/patch release (6.11.3).
   
   In addition, I added an .nvmrc file to the Management UI so that local developers using nvm will be able to use the same version as our production build.
   
   ## Testing
   There shouldn't be a noticeable difference since node v10 is just the LTS release of v9 and npm is primarily used to manage front-end dependencies. If you run `mvn install -pl ':metron-config'` and `mvn install -pl ':metron-alerts'`, you will notice the versions of node and npm mentioned above are installed. The tests suites for both UIs will also be ran and should pass. To visually test for regressions, spin up full dev and open both the Alerts and Management UI. You should see no differences.
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions.
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services