You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/15 00:08:32 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6743: WIP(feature): jsonrpc4j plugin

wu-sheng commented on a change in pull request #6743:
URL: https://github.com/apache/skywalking/pull/6743#discussion_r613662302



##########
File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -194,4 +194,8 @@
     public static final OfficialComponent APACHE_CXF = new OfficialComponent(105, "Apache-CXF");
 
     public static final OfficialComponent DOLPHIN_SCHEDULER = new OfficialComponent(106, "dolphinscheduler");
+
+    public static final OfficialComponent JSON_RPC_CLIENT = new OfficialComponent(107, "JsonRpcClient");
+
+    public static final OfficialComponent JSON_RPC_SERVER = new OfficialComponent(108, "JsonRpcServer");

Review comment:
       We usually share one component ID at both client and server sides.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org