You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 13:24:23 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #10366: [Release] Fixes to release script

jorgecarleitao opened a new pull request #10366:
URL: https://github.com/apache/arrow/pull/10366


   These are two minor fixes to the release.
   
   1. Made git not fetch the 15k tags on crossbow and instead. This was causing timeouts
   2. pass the `ARTIFACTORY_API_KEY` to the docker image so that it can use it in pushing artifacts
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #10366: ARROW-13468: [Release] Fix binary download/upload failures

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10366:
URL: https://github.com/apache/arrow/pull/10366#discussion_r677776289



##########
File path: dev/release/04-binary-download.sh
##########
@@ -36,4 +36,4 @@ crossbow_job_prefix="release-${version_with_rc}"
 : ${CROSSBOW_JOB_NUMBER:="0"}
 : ${CROSSBOW_JOB_ID:="${crossbow_job_prefix}-${CROSSBOW_JOB_NUMBER}"}
 
-archery crossbow download-artifacts ${CROSSBOW_JOB_ID}
+archery crossbow download-artifacts ${CROSSBOW_JOB_ID} --no-fetch

Review comment:
       We can revisit this when this causes a problem.
   
   For example, we can use `CROSSBOW_ARGS` environment variable to customize this behavior:
   
   ```bash
   : ${CROSSBOW_ARGS:=--no-fetch}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #10366: [Release] Fixes to release script

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10366:
URL: https://github.com/apache/arrow/pull/10366#discussion_r636474104



##########
File path: dev/release/05-binary-upload.sh
##########
@@ -128,6 +128,7 @@ docker_run \
   ./runner.sh \
   rake \
     "${rake_tasks[@]}" \
+    ARTIFACTORY_API_KEY="${ARTIFACTORY_API_KEY}" \
     APT_TARGETS=$(IFS=,; echo "${apt_targets[*]}") \

Review comment:
       Oh, thanks! I don't know why I could upload without this...
   
   Could you keep this list in alphabetical order?
   
   ```suggestion
       APT_TARGETS=$(IFS=,; echo "${apt_targets[*]}") \
       ARTIFACTORY_API_KEY="${ARTIFACTORY_API_KEY}" \
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #10366: ARROW-13468: [Release] Fix binary download/upload failures

Posted by GitBox <gi...@apache.org>.
kou closed pull request #10366:
URL: https://github.com/apache/arrow/pull/10366


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10366: [Release] Fixes to release script

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10366:
URL: https://github.com/apache/arrow/pull/10366#issuecomment-845317294


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10366: ARROW-13468: [Release] Fix binary download/upload failures

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10366:
URL: https://github.com/apache/arrow/pull/10366#issuecomment-887811471


   https://issues.apache.org/jira/browse/ARROW-13468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #10366: [Release] Fixes to release script

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10366:
URL: https://github.com/apache/arrow/pull/10366#discussion_r636116814



##########
File path: dev/release/04-binary-download.sh
##########
@@ -36,4 +36,4 @@ crossbow_job_prefix="release-${version_with_rc}"
 : ${CROSSBOW_JOB_NUMBER:="0"}
 : ${CROSSBOW_JOB_ID:="${crossbow_job_prefix}-${CROSSBOW_JOB_NUMBER}"}
 
-archery crossbow download-artifacts ${CROSSBOW_JOB_ID}
+archery crossbow download-artifacts ${CROSSBOW_JOB_ID} --no-fetch

Review comment:
       It only works if the job from submitted from the same machine - which should be true in most of the cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org