[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18908: [improvement](profile) Insert into add LoadChannel runtime profile

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #18908:
URL: https://github.com/apache/doris/pull/18908#discussion_r1173602289


##########
be/src/util/runtime_profile.cpp:
##########
@@ -625,6 +712,62 @@ std::string RuntimeProfile::print_json_info(const std::string& profile_name, std
     return s.GetString();
 }
 
+void RuntimeProfile::to_proto(PRuntimeProfileTree* tree) {

Review Comment:
   warning: method 'to_proto' can be made const [readability-make-member-function-const]
   
   be/src/util/runtime_profile.h:343:
   ```diff
   -     void to_proto(PRuntimeProfileTree* tree);
   +     void to_proto(PRuntimeProfileTree* tree) const;
   ```
   
   ```suggestion
   void RuntimeProfile::to_proto(PRuntimeProfileTree* tree) const {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org