You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/06 07:37:55 UTC
[GitHub] [shardingsphere] TaoZhiMLND opened a new pull request #5436: fix TableMetaData load error when use oracle.
TaoZhiMLND opened a new pull request #5436:
URL: https://github.com/apache/shardingsphere/pull/5436
Fixes #5421.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5436: fix TableMetaData load error when use oracle.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5436:
URL: https://github.com/apache/shardingsphere/pull/5436#issuecomment-624593619
## Pull Request Test Coverage Report for [Build 11443](https://coveralls.io/builds/30596729)
* **1** of **3** **(33.33%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.003%**) to **56.991%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/index/IndexMetaDataLoader.java](https://coveralls.io/builds/30596729/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Findex%2FIndexMetaDataLoader.java#L50) | 0 | 2 | 0.0%
<!-- | **Total:** | **1** | **3** | **33.33%** | -->
| Totals | [](https://coveralls.io/builds/30596729) |
| :-- | --: |
| Change from base [Build 11440](https://coveralls.io/builds/30596059): | -0.003% |
| Covered Lines: | 11992 |
| Relevant Lines: | 21042 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5436: fix TableMetaData load error when use oracle.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5436:
URL: https://github.com/apache/shardingsphere/pull/5436#issuecomment-624593619
## Pull Request Test Coverage Report for [Build 11439](https://coveralls.io/builds/30595669)
* **2** of **4** **(50.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.005%**) to **56.988%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/index/IndexMetaDataLoader.java](https://coveralls.io/builds/30595669/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Findex%2FIndexMetaDataLoader.java#L50) | 0 | 2 | 0.0%
<!-- | **Total:** | **2** | **4** | **50.0%** | -->
| Totals | [](https://coveralls.io/builds/30595669) |
| :-- | --: |
| Change from base [Build 11432](https://coveralls.io/builds/30590706): | -0.005% |
| Covered Lines: | 11992 |
| Relevant Lines: | 21043 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #5436: fix TableMetaData load error when use oracle.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5436:
URL: https://github.com/apache/shardingsphere/pull/5436#discussion_r420691585
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/index/IndexMetaDataLoader.java
##########
@@ -47,6 +47,9 @@
try (ResultSet resultSet = connection.getMetaData().getIndexInfo(connection.getCatalog(), connection.getSchema(), table, false, false)) {
while (resultSet.next()) {
String indexName = resultSet.getString(INDEX_NAME);
+ if (null == indexName) {
+ continue;
+ }
result.add(new IndexMetaData(indexName));
Review comment:
It is better to:
```java
if (null != indexName) {
result.add(new IndexMetaData(indexName));
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org